Allow macros to call method returning implicit functions #5299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Extracted from #5297 |
|
I first tried to call the method and then call reflectively the apply method of the lambda. This did not work, the reflective call crashed saying that it cannot call a method marked as "public" 😂. |
nicolasstucki
force-pushed
the
fix-macro-with-implicit-fun-type
branch
from
ab2a098 to
b8aac4d
Compare
|
CI is not happy. |
nicolasstucki
force-pushed
the
fix-macro-with-implicit-fun-type
branch
from
b8aac4d to
659e7ee
Compare
|
Fixed it |
nicolasstucki
commented
Oct 22, 2018
| @@ -347,6 +347,8 @@ object Splicer { | |||
|
|
|||
| object Call { | |||
| def unapply(arg: Tree): Option[(RefTree, List[Tree])] = arg match { | |||
| case Select(Call(fn, args), nme.apply) if defn.isImplicitFunctionType(fn.tpe.widenDealias.finalResultType) => | |||
There was a problem hiding this comment.
I was missing this guard.
|
Fixed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.