Skip to content

Fix management of compiler instances of quoted.Expr run and show #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix management of compiler instances of quoted.Expr run and show #5297

wants to merge 2 commits into from

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Oct 19, 2018 •
edited
Loading

Changes:

Downsides:

  • The context must be passed everywhere (but was already there for macros). Implicit function types help to minimize syntactic overhead.

@nicolasstucki nicolasstucki self-assigned this Oct 19, 2018
@nicolasstucki nicolasstucki mentioned this pull request Oct 19, 2018
Merged
@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch 6 times, most recently from 299341f to 6d9ae45 Compare October 23, 2018 12:13
@nicolasstucki nicolasstucki mentioned this pull request Oct 23, 2018
Merged
@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch 11 times, most recently from 10379de to 775c739 Compare October 29, 2018 12:54
@nicolasstucki nicolasstucki mentioned this pull request Oct 30, 2018
Merged
@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch 2 times, most recently from 83265b8 to 49e667f Compare October 30, 2018 19:51
@yallop yallop mentioned this pull request Nov 2, 2018
Closed
@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch 2 times, most recently from 217f63f to f97f6f0 Compare November 2, 2018 18:28
@nicolasstucki
Copy link
Contributor Author

Fixes #5376

@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch 3 times, most recently from 488441b to 4dfde20 Compare November 23, 2018 19:42
@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch 2 times, most recently from 6e1474f to fe6f00a Compare November 29, 2018 08:36
@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch 3 times, most recently from a860820 to ac2452d Compare December 7, 2018 18:44
@nicolasstucki nicolasstucki mentioned this pull request Dec 12, 2018
Closed
@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch 3 times, most recently from 92d0302 to 15f6d80 Compare December 17, 2018 10:31
@nicolasstucki nicolasstucki mentioned this pull request Dec 17, 2018
Closed
@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch 2 times, most recently from b177e61 to 0c4f745 Compare December 18, 2018 11:07
@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch 3 times, most recently from b555097 to 3fe7e58 Compare January 8, 2019 16:05
@nicolasstucki nicolasstucki mentioned this pull request Mar 6, 2019
Merged
@liufengyun
Copy link
Contributor

@nicolasstucki This needs rebase.

@nicolasstucki
Fix management of compiler instances of quoted.Expr run and show
2d85dba 
Changes:
* Make quotes eager: fixes scala#5376 (requires context)
* Fix bugs shown in scala#5429: Tree from the macro parameters is passed to another compiler to show it.
* Protect against scope extrusion with early (meaningful) runtime failure (rather than in the compiler)
* Add an implicit function type to provide context.
* Fixes scala#5161
@nicolasstucki
WIP fix after rebase
901cd0f
@nicolasstucki nicolasstucki force-pushed the eager-quote-unpicking branch from 3fe7e58 to 901cd0f Compare May 7, 2019 08:15
@nicolasstucki
Copy link
Contributor Author

Replaced by the PRs listed in #6688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky requested changes

@biboudis biboudis Awaiting requested review from biboudis

Assignees

@nicolasstucki nicolasstucki

Labels
stat:wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quotation unexpectedly creates cyclic structures ArrayIndexOutOfBoundsException while unpickling quote
5 participants
@nicolasstucki @dottybot @biboudis @liufengyun @odersky