Fix go to definition with overridden methods
#5208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing go to definition on a reference, we are supposed to look for the symbol under the cursor, and the symbols that override it in the same source file. We were previously looking only in the tree of the first definition, and would not inspect the rest of the sourcefile.
Duhemm
force-pushed
the
fix/go-to-definition-overridden
branch
from
632f3cc to
214e277
Compare
smarter
approved these changes
Oct 10, 2018
There was a problem hiding this comment.
LGTM, but I think we should simplify the logic here and look for definitions in the whole codebase all the time, it's slow the first time but now that we have a cache it's not too bad afterwards. (Eventually it'd be great if we could stream responses to queries so that we can both have a fast first response and a complete response afterwards, but that still seems a long way off: microsoft/language-server-protocol#182)
|
(Note that my suggestions are for future improvements, this is good to go as is) |
Duhemm
added a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 19, 2018
When doing go-to-definition, we used to look for symbols that override the symbol selected for go to definition only in the same source file as the one that was selected. This commit changes that, as suggested in the review of scala#5208.
Duhemm
added a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 30, 2018
When doing go-to-definition, we used to look for symbols that override the symbol selected for go to definition only in the same source file as the one that was selected. This commit changes that, as suggested in the review of scala#5208.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing go to definition on a reference, we are supposed to look for
the symbol under the cursor, and the symbols that override it in the
same source file. We were previously looking only in the tree of the
first definition, and would not inspect the rest of the sourcefile.