Support for multi-project find all references
#5209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duhemm
force-pushed
the
topic/ide-multi-project-references
branch
3 times, most recently
from
73cf3e0 to
d48548e
Compare
Duhemm
force-pushed
the
topic/ide-multi-project-references
branch
from
d48548e to
0f8853a
Compare
smarter
reviewed
Nov 9, 2018
language-server/src/dotty/tools/languageserver/config/ProjectConfig.java
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/interactive/InteractiveDriver.scala
Outdated
Show resolved
Hide resolved
| symbol.ownersIterator.toList.reverse.map(_.name) | ||
| } | ||
| in(targetDriver) { implicit ctx => | ||
| val base: Symbol = ctx.definitions.RootClass |
There was a problem hiding this comment.
Does this work for symbols in the empty package ? Definition#staticRef has a special case to handle that.
There was a problem hiding this comment.
I think it works, see this test for instance:
compiler/src/dotty/tools/dotc/interactive/InteractiveDriver.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/interactive/InteractiveDriver.scala
Outdated
Show resolved
Hide resolved
language-server/src/dotty/tools/languageserver/DottyLanguageServer.scala
Outdated
Show resolved
Hide resolved
This field will be used to restrict which projects to inspect when doing workspace-wide rename or finding all references. The code that extracts dependency information from sbt has been ported from scalacenter/bloop: https://github.com/scalacenter/bloop/blob/v1.0.0/integrations/sbt-bloop/src/main/scala/bloop/integrations/sbt/SbtBloop.scala
This commit adapts the `find all references` feature so that it is able to find references to given symbols across projects. For symbols that come from the classpath, all the projects in the build will be inspected. If we're able to find a source for the symbol, only the projects that depend on the projects where we found the definition need to be inspected.
(This commit contains no functional change)
This is necessary because we may be using this InteractiveDriver before asking it to compile anything (which would have initialized it). This happens, for instance, if we use this Driver to resolve a symbol coming from a different Driver. Drivers are not meant to be used before being initialized and can crash.
It appears that the `TreeUnpickler` is not able to be run in parallel.
Duhemm
force-pushed
the
topic/ide-multi-project-references
branch
from
0f8853a to
d5280a6
Compare
|
@smarter I've addressed your comments |
smarter
reviewed
Nov 12, 2018
smarter
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts the
find all referencesfeature so that it is ableto find references to given symbols across projects. For symbols that
come from the classpath, all the projects in the build will be
inspected. If we're able to find a source for the symbol, only the
projects that depend on the projects where we found the definition need
to be inspected.