Upgrade to Scala 2.12.7, fix compilation and running tests on Java 11

.drone.yml

@@ -23,23 +23,23 @@ pipeline:
   # We run tests in parallel. Tests run in a copy of the working directory to avoid conflict
   test:
     group: test
-    image: lampepfl/dotty:2018-09-14-2
+    image: lampepfl/dotty:2018-10-01
     commands:
       - cp -R . /tmp/1/ && cd /tmp/1/
       - ./project/scripts/sbt ";compile ;test"
       - ./project/scripts/cmdTests
 
   test_bootstrapped:
     group: test
-    image: lampepfl/dotty:2018-09-14-2
+    image: lampepfl/dotty:2018-10-01
     commands:
       - cp -R . /tmp/2/ && cd /tmp/2/
       - ./project/scripts/sbt ";dotty-bootstrapped/compile ;dotty-bootstrapped/test"
       - ./project/scripts/bootstrapCmdTests
 
   test_sbt:
     group: test
-    image: lampepfl/dotty:2018-09-14-2
+    image: lampepfl/dotty:2018-10-01
     commands:
       - cp -R . /tmp/4/ && cd /tmp/4/
       - ./project/scripts/sbt sbt-dotty/scripted
@@ -49,7 +49,7 @@ pipeline:
 
   # DOCUMENTATION:
   documentation:
-    image: lampepfl/dotty:2018-09-14-2
+    image: lampepfl/dotty:2018-10-01
     commands:
       - ./project/scripts/genDocs
     secrets: [ bot_pass ]
@@ -61,7 +61,7 @@ pipeline:
   # PUBLISHING:
   # Publishing expect NIGHTLYBUILD or RELEASEBUILD to be set. See dottyVersion in Build.scala
   publish_nightly:
-    image: lampepfl/dotty:2018-09-14-2
+    image: lampepfl/dotty:2018-10-01
     environment:
       - NIGHTLYBUILD=yes
     commands:
@@ -72,7 +72,7 @@ pipeline:
       environment: nightly
 
   publish_release:
-    image: lampepfl/dotty:2018-09-14-2
+    image: lampepfl/dotty:2018-10-01
     environment:
       - RELEASEBUILD=yes
     commands:
@@ -96,7 +96,7 @@ pipeline:
       event: tag
 
   publish_sbt_release:
-    image: lampepfl/dotty:2018-09-14-2
+    image: lampepfl/dotty:2018-10-01
     environment:
       - RELEASEBUILD=yes
     commands:

compiler/src/dotty/tools/dotc/reporting/MessageRendering.scala

@@ -91,15 +91,15 @@ trait MessageRendering {
     * @return aligned error message
     */
   def errorMsg(pos: SourcePosition, msg: String, offset: Int)(implicit ctx: Context): String = {
-    val padding = msg.lines.foldLeft(pos.startColumnPadding) { (pad, line) =>
+    val padding = msg.linesIterator.foldLeft(pos.startColumnPadding) { (pad, line) =>
       val lineLength = stripColor(line).length
       val maxPad = math.max(0, ctx.settings.pageWidth.value - offset - lineLength) - offset
 
       if (maxPad < pad.length) " " * maxPad
       else pad
     }
 
-    msg.lines
+    msg.linesIterator
       .map { line => " " * (offset - 1) + "|" + padding + line}
       .mkString(sys.props("line.separator"))
   }

compiler/test-resources/type-printer/prefixless

@@ -7,4 +7,4 @@ val res2: Seq[Char] = List(a, b)
 scala> Set(4, 5)
 val res3: Set[Int] = Set(4, 5)
 scala> Iterator(1)
-val res4: Iterator[Int] = non-empty iterator
+val res4: Iterator[Int] = <iterator>

compiler/test/dotty/tools/vulpix/ParallelTesting.scala

@@ -613,7 +613,7 @@ trait ParallelTesting extends RunnerOrchestration { self =>
       else runMain(testSource.runClassPath) match {
         case Success(_) if !checkFile.isDefined || !checkFile.get.exists => // success!
         case Success(output) => {
-          val outputLines = output.lines.toArray :+ DiffUtil.EOF
+          val outputLines = output.linesIterator.toArray :+ DiffUtil.EOF
           val checkLines: Array[String] = Source.fromFile(checkFile.get).getLines().toArray :+ DiffUtil.EOF
           val sourceTitle = testSource.title
 
@@ -1027,7 +1027,7 @@ trait ParallelTesting extends RunnerOrchestration { self =>
         case test.TimeoutFailure(title) =>
           s"  - test '$title' timed out"
         case test.JavaCompilationFailure(msg) =>
-          s"  - java compilation failed with:\n${ msg.lines.map("      " + _).mkString("\n") }"
+          s"  - java compilation failed with:\n${ msg.linesIterator.map("      " + _).mkString("\n") }"
       }.mkString("\n")
     }
 

dist/bin/common

@@ -61,14 +61,6 @@ if [ ! -x "$JAVACMD" ] ; then
   exit 1
 fi
 
-# parses 1.7, 1.8, 9, etc out of java version "1.8.0_91"
-JAVA_VERSION=$("$JAVACMD" -version 2>&1 | grep ' version "' | tr '\r' '\n' | sed 's/.*version "\([0-9]*\)\(\.[0-9]*\)\{0,1\}\(.*\)*"/\1\2/; 1q')
-
-if [ "$JAVA_VERSION" != "1.8" ] ; then
-  echo "Error: Java 8 is required, actual $JAVA_VERSION"
-  exit 1
-fi
-
 if [ -z "$JAVA_HOME" ] ; then
   echo "Warning: JAVA_HOME environment variable is not set."
 fi

doc-tool/src/dotty/tools/dottydoc/model/comment/CommentCleaner.scala

@@ -21,6 +21,6 @@ trait CommentCleaner {
       SafeTags.replaceAllIn(javadoclessComment, { mtch =>
         Matcher.quoteReplacement(safeTagMarker + mtch.matched + safeTagMarker)
       })
-    markedTagComment.lines.toList map (cleanLine)
+    markedTagComment.linesIterator.toList map (cleanLine)
   }
 }

doc-tool/src/dotty/tools/dottydoc/staticsite/Page.scala

@@ -115,7 +115,7 @@ trait Page {
     val withoutYaml = virtualFile(
       if (content.startsWith("---\n")) {
         val str =
-          content.lines
+          content.linesIterator
           .drop(1)
           .dropWhile(line => line != "---" && line != "...")
           .drop(1).mkString("\n")

project/Build.scala

@@ -36,7 +36,7 @@ object ExposedValues extends AutoPlugin {
 object Build {
 
   val baseVersion = "0.10.0"
-  val scalacVersion = "2.12.6"
+  val scalacVersion = "2.12.7"
 
   val dottyOrganization = "ch.epfl.lamp"
   val dottyGithubUrl = "https://github.com/lampepfl/dotty"

tests/run/richs.scala

@@ -75,11 +75,11 @@ object RichStringTest1 extends RichTest {
 object RichStringTest2 extends RichTest {
   def run: Unit = {
     println("\n" + getObjectName + ":")
-    Console.print("s1: "); s1.lines foreach println
-    Console.print("s2: "); s2.lines foreach println
-    Console.print("s3: "); s3.lines foreach println
-    Console.print("s4: "); s4.lines foreach println
-    Console.print("s5: "); s5.lines foreach println
+    Console.print("s1: "); s1.linesIterator foreach println
+    Console.print("s2: "); s2.linesIterator foreach println
+    Console.print("s3: "); s3.linesIterator foreach println
+    Console.print("s4: "); s4.linesIterator foreach println
+    Console.print("s5: "); s5.linesIterator foreach println
   }
 }
 object RichStringTest3 extends RichTest {

tests/run/t6827.scala

@@ -8,6 +8,16 @@ object Test extends App {
       it.copyToArray(arr, start, len)
       "ok"
     } catch {
+      case e: ArrayIndexOutOfBoundsException =>
+        // Special-case printing this exception because the toString changed in Java 11
+        val java11toString = """java.lang.ArrayIndexOutOfBoundsException: Index (-?\d+).*""".r
+
+        e.toString match {
+          case java11toString(index) =>
+            s"java.lang.ArrayIndexOutOfBoundsException: $index"
+          case str =>
+            str
+        }
       case e: Exception => e.toString
     }
     println("%s: %s" format (label, status))

tests/run/t8015-ffc.scala

@@ -2,6 +2,6 @@
 object Test extends dotty.runtime.LegacyApp {
   val ms = """This is a long multiline string
   with \u000d\u000a CRLF embedded."""
-  assert(ms.lines.size == 3, s"lines.size ${ms.lines.size}")
+  assert(ms.linesIterator.size == 3, s"lines.size ${ms.linesIterator.size}")
   assert(ms contains "\r\n CRLF", "no CRLF")
 }

tests/run/t8690.check

@@ -1,2 +1,2 @@
-non-empty iterator
+<iterator>
 abcdef

tests/run/view-iterator-stream.check

@@ -4,109 +4,109 @@
 -------------------
 toIndexedSeq -> toIterator -> toStream        Stream(22, ?)                  22 23 24 25
 toIndexedSeq -> toIterator -> view            StreamView(...)                22 23 24 25
-toIndexedSeq -> toStream -> toIterator        non-empty iterator             22 23 24 25
+toIndexedSeq -> toStream -> toIterator        <iterator>                     22 23 24 25
 toIndexedSeq -> toStream -> view              StreamView(...)                22 23 24 25
-toIndexedSeq -> view -> toIterator            non-empty iterator             22 23 24 25
+toIndexedSeq -> view -> toIterator            <iterator>                     22 23 24 25
 toIndexedSeq -> view -> toStream              Stream(22, ?)                  22 23 24 25
 toIterator -> toIndexedSeq -> toStream        Stream(22, ?)                  22 23 24 25
 toIterator -> toIndexedSeq -> view            SeqView(...)                   22 23 24 25
 toIterator -> toStream -> toIndexedSeq        Vector(22, 23, 24, 25)         22 23 24 25
 toIterator -> toStream -> view                StreamView(...)                22 23 24 25
 toIterator -> view -> toIndexedSeq            Vector(22, 23, 24, 25)         22 23 24 25
 toIterator -> view -> toStream                Stream(22, ?)                  22 23 24 25
-toStream -> toIndexedSeq -> toIterator        non-empty iterator             22 23 24 25
+toStream -> toIndexedSeq -> toIterator        <iterator>                     22 23 24 25
 toStream -> toIndexedSeq -> view              SeqView(...)                   22 23 24 25
 toStream -> toIterator -> toIndexedSeq        Vector(22, 23, 24, 25)         22 23 24 25
 toStream -> toIterator -> view                StreamView(...)                22 23 24 25
 toStream -> view -> toIndexedSeq              Vector(22, 23, 24, 25)         22 23 24 25
-toStream -> view -> toIterator                non-empty iterator             22 23 24 25
-view -> toIndexedSeq -> toIterator            non-empty iterator             22 23 24 25
+toStream -> view -> toIterator                <iterator>                     22 23 24 25
+view -> toIndexedSeq -> toIterator            <iterator>                     22 23 24 25
 view -> toIndexedSeq -> toStream              Stream(22, ?)                  22 23 24 25
 view -> toIterator -> toIndexedSeq            Vector(22, 23, 24, 25)         22 23 24 25
 view -> toIterator -> toStream                Stream(22, ?)                  22 23 24 25
 view -> toStream -> toIndexedSeq              Vector(22, 23, 24, 25)         22 23 24 25
-view -> toStream -> toIterator                non-empty iterator             22 23 24 25
+view -> toStream -> toIterator                <iterator>                     22 23 24 25
 
 ** take 20 -> drop 10 -> slice(1, 5) **
 
 -------------------
 toIndexedSeq -> toIterator -> toStream        Stream(12, ?)                  12 13 14 15
 toIndexedSeq -> toIterator -> view            StreamView(...)                12 13 14 15
-toIndexedSeq -> toStream -> toIterator        non-empty iterator             12 13 14 15
+toIndexedSeq -> toStream -> toIterator        <iterator>                     12 13 14 15
 toIndexedSeq -> toStream -> view              StreamView(...)                12 13 14 15
-toIndexedSeq -> view -> toIterator            non-empty iterator             12 13 14 15
+toIndexedSeq -> view -> toIterator            <iterator>                     12 13 14 15
 toIndexedSeq -> view -> toStream              Stream(12, ?)                  12 13 14 15
 toIterator -> toIndexedSeq -> toStream        Stream(12, ?)                  12 13 14 15
 toIterator -> toIndexedSeq -> view            SeqView(...)                   12 13 14 15
 toIterator -> toStream -> toIndexedSeq        Vector(12, 13, 14, 15)         12 13 14 15
 toIterator -> toStream -> view                StreamView(...)                12 13 14 15
 toIterator -> view -> toIndexedSeq            Vector(12, 13, 14, 15)         12 13 14 15
 toIterator -> view -> toStream                Stream(12, ?)                  12 13 14 15
-toStream -> toIndexedSeq -> toIterator        non-empty iterator             12 13 14 15
+toStream -> toIndexedSeq -> toIterator        <iterator>                     12 13 14 15
 toStream -> toIndexedSeq -> view              SeqView(...)                   12 13 14 15
 toStream -> toIterator -> toIndexedSeq        Vector(12, 13, 14, 15)         12 13 14 15
 toStream -> toIterator -> view                StreamView(...)                12 13 14 15
 toStream -> view -> toIndexedSeq              Vector(12, 13, 14, 15)         12 13 14 15
-toStream -> view -> toIterator                non-empty iterator             12 13 14 15
-view -> toIndexedSeq -> toIterator            non-empty iterator             12 13 14 15
+toStream -> view -> toIterator                <iterator>                     12 13 14 15
+view -> toIndexedSeq -> toIterator            <iterator>                     12 13 14 15
 view -> toIndexedSeq -> toStream              Stream(12, ?)                  12 13 14 15
 view -> toIterator -> toIndexedSeq            Vector(12, 13, 14, 15)         12 13 14 15
 view -> toIterator -> toStream                Stream(12, ?)                  12 13 14 15
 view -> toStream -> toIndexedSeq              Vector(12, 13, 14, 15)         12 13 14 15
-view -> toStream -> toIterator                non-empty iterator             12 13 14 15
+view -> toStream -> toIterator                <iterator>                     12 13 14 15
 
 ** slice(20, 40) -> drop 10 -> take 5 **
 
 -------------------
 toIndexedSeq -> toIterator -> toStream        Stream(31, ?)                  31 32 33 34 35
 toIndexedSeq -> toIterator -> view            StreamView(...)                31 32 33 34 35
-toIndexedSeq -> toStream -> toIterator        non-empty iterator             31 32 33 34 35
+toIndexedSeq -> toStream -> toIterator        <iterator>                     31 32 33 34 35
 toIndexedSeq -> toStream -> view              StreamView(...)                31 32 33 34 35
-toIndexedSeq -> view -> toIterator            non-empty iterator             31 32 33 34 35
+toIndexedSeq -> view -> toIterator            <iterator>                     31 32 33 34 35
 toIndexedSeq -> view -> toStream              Stream(31, ?)                  31 32 33 34 35
 toIterator -> toIndexedSeq -> toStream        Stream(31, ?)                  31 32 33 34 35
 toIterator -> toIndexedSeq -> view            SeqView(...)                   31 32 33 34 35
 toIterator -> toStream -> toIndexedSeq        Vector(31, 32, 33, 34, 35)     31 32 33 34 35
 toIterator -> toStream -> view                StreamView(...)                31 32 33 34 35
 toIterator -> view -> toIndexedSeq            Vector(31, 32, 33, 34, 35)     31 32 33 34 35
 toIterator -> view -> toStream                Stream(31, ?)                  31 32 33 34 35
-toStream -> toIndexedSeq -> toIterator        non-empty iterator             31 32 33 34 35
+toStream -> toIndexedSeq -> toIterator        <iterator>                     31 32 33 34 35
 toStream -> toIndexedSeq -> view              SeqView(...)                   31 32 33 34 35
 toStream -> toIterator -> toIndexedSeq        Vector(31, 32, 33, 34, 35)     31 32 33 34 35
 toStream -> toIterator -> view                StreamView(...)                31 32 33 34 35
 toStream -> view -> toIndexedSeq              Vector(31, 32, 33, 34, 35)     31 32 33 34 35
-toStream -> view -> toIterator                non-empty iterator             31 32 33 34 35
-view -> toIndexedSeq -> toIterator            non-empty iterator             31 32 33 34 35
+toStream -> view -> toIterator                <iterator>                     31 32 33 34 35
+view -> toIndexedSeq -> toIterator            <iterator>                     31 32 33 34 35
 view -> toIndexedSeq -> toStream              Stream(31, ?)                  31 32 33 34 35
 view -> toIterator -> toIndexedSeq            Vector(31, 32, 33, 34, 35)     31 32 33 34 35
 view -> toIterator -> toStream                Stream(31, ?)                  31 32 33 34 35
 view -> toStream -> toIndexedSeq              Vector(31, 32, 33, 34, 35)     31 32 33 34 35
-view -> toStream -> toIterator                non-empty iterator             31 32 33 34 35
+view -> toStream -> toIterator                <iterator>                     31 32 33 34 35
 
 ** slice(20, 40) -> take 10 -> drop 5 **
 
 -------------------
 toIndexedSeq -> toIterator -> toStream        Stream(26, ?)                  26 27 28 29 30
 toIndexedSeq -> toIterator -> view            StreamView(...)                26 27 28 29 30
-toIndexedSeq -> toStream -> toIterator        non-empty iterator             26 27 28 29 30
+toIndexedSeq -> toStream -> toIterator        <iterator>                     26 27 28 29 30
 toIndexedSeq -> toStream -> view              StreamView(...)                26 27 28 29 30
-toIndexedSeq -> view -> toIterator            non-empty iterator             26 27 28 29 30
+toIndexedSeq -> view -> toIterator            <iterator>                     26 27 28 29 30
 toIndexedSeq -> view -> toStream              Stream(26, ?)                  26 27 28 29 30
 toIterator -> toIndexedSeq -> toStream        Stream(26, ?)                  26 27 28 29 30
 toIterator -> toIndexedSeq -> view            SeqView(...)                   26 27 28 29 30
 toIterator -> toStream -> toIndexedSeq        Vector(26, 27, 28, 29, 30)     26 27 28 29 30
 toIterator -> toStream -> view                StreamView(...)                26 27 28 29 30
 toIterator -> view -> toIndexedSeq            Vector(26, 27, 28, 29, 30)     26 27 28 29 30
 toIterator -> view -> toStream                Stream(26, ?)                  26 27 28 29 30
-toStream -> toIndexedSeq -> toIterator        non-empty iterator             26 27 28 29 30
+toStream -> toIndexedSeq -> toIterator        <iterator>                     26 27 28 29 30
 toStream -> toIndexedSeq -> view              SeqView(...)                   26 27 28 29 30
 toStream -> toIterator -> toIndexedSeq        Vector(26, 27, 28, 29, 30)     26 27 28 29 30
 toStream -> toIterator -> view                StreamView(...)                26 27 28 29 30
 toStream -> view -> toIndexedSeq              Vector(26, 27, 28, 29, 30)     26 27 28 29 30
-toStream -> view -> toIterator                non-empty iterator             26 27 28 29 30
-view -> toIndexedSeq -> toIterator            non-empty iterator             26 27 28 29 30
+toStream -> view -> toIterator                <iterator>                     26 27 28 29 30
+view -> toIndexedSeq -> toIterator            <iterator>                     26 27 28 29 30
 view -> toIndexedSeq -> toStream              Stream(26, ?)                  26 27 28 29 30
 view -> toIterator -> toIndexedSeq            Vector(26, 27, 28, 29, 30)     26 27 28 29 30
 view -> toIterator -> toStream                Stream(26, ?)                  26 27 28 29 30
 view -> toStream -> toIndexedSeq              Vector(26, 27, 28, 29, 30)     26 27 28 29 30
-view -> toStream -> toIterator                non-empty iterator             26 27 28 29 30
+view -> toStream -> toIterator                <iterator>                     26 27 28 29 30