Upgrade to Scala 2.12.7, fix compilation and running tests on Java 11 #5175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
upgrade-2.12.7
branch
3 times, most recently
from
d38eb74 to
fda5095
Compare
smarter
changed the title
smarter
force-pushed
the
upgrade-2.12.7
branch
2 times, most recently
from
656c2b6 to
32f3ca5
Compare
The Iterator#toString change comes from scala/scala#6668
The extension method lines is now shadowed by String#lines that returns a Stream, use linesIterator instead (it used to be deprecated in favor of lines, but has been undeprecated in 2.12.7)
This test depends on some proprietary JDK APIs that don't appear to exist anymore on Java 9+
smarter
force-pushed
the
upgrade-2.12.7
branch
from
32f3ca5 to
890e09a
Compare
allanrenucci
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.