Make LazyVals implement non-static modules. Move LV after erasure. #493

DarkDimius · 2015-04-22T11:52:45Z

Known to fail due data-race in pos/S5.

DarkDimius · 2015-04-22T11:59:49Z

@odersky can you take this over?
This changes seem to reveal a data race due to TreeTypeMap in changeOwner in pos/S5 and pos/t0453.

DarkDimius · 2015-04-22T12:05:45Z

a0bb466 is here to workaround #494, but I believe it's generally better to implement mini-phases without prepareXXX methods.

odersky · 2015-04-22T16:46:29Z

There's indeed a problem relating Mixin and Memoize. Memoize does not generate the required fields
for getters and setters introduced by Mixin. The transformFollowing would fix that, except it causes other problems. Still investigating...

DarkDimius · 2015-04-23T15:48:24Z

@odersky test is failing as you have lost some of the changes while rewriting history. If you are done, I'll take this PR over.

odersky · 2015-04-23T15:53:52Z

@DarkDimius OK, over to you,

DarkDimius · 2015-04-24T10:15:22Z

Current state: fails Ychecking after LambdaLift.

DarkDimius · 2015-04-28T09:33:49Z

af680d4 was very tricky to catch. Took two days.
@odersky please review.

DarkDimius · 2015-04-28T10:54:10Z

Two last commits enable compiling down to bytecode for all tests, and compile Dotty itself.
Though it still does not run.

odersky · 2015-04-28T11:50:41Z

We get an OutOfMemory error on this one. What's our heap size here?

odersky · 2015-04-28T12:01:29Z

src/dotty/tools/dotc/ast/tpd.scala

+    val sym = ctx.newSymbol(owner, nme.WHILE_PREFIX, Flags.Label | Flags.Synthetic,
+      MethodType(Nil, defn.UnitType), coord = cond.pos)
+
+    val call = Apply(ref(sym), Nil)


Use ref(sym).appliedToNone? (Not a strong opinion on this).

odersky · 2015-04-28T13:45:29Z

That's all I have.

DarkDimius · 2015-04-28T19:22:06Z

I'll perform renamings in upcoming commit.

…nits.

@DarkDimius

[@DarkDimius] I see no good reason for this, as it creates tight coupling between `ifs` in two methods. [@odersky] The reason is probably in the deleted comment: // allocate field early so that initializer has the right owner for subsequent phases in // the group. We now transform the rhs in subsequent phases with the getter as owner, where before it was the field. It is not clear to me whether this matters or not. [Update] We figured out the problem: It was a missing changeOwnerAfter in Constructor. Added to next commit.

Erasure finishes work done by Explicit outer, and registers a post condition that This(outer) is not allowed.

…se long.

Was creating correct code, but was assuming that all objects with the same name share same bits. No need to do it.

… an old one.

Hurray!

Values are the ones that I got as maximum values for compiling dotty itself.

DarkDimius · 2015-04-30T13:46:13Z

Out of memory on travis solved.
Now build on travis runs constrained to 1G of memory, 2Mb of stack.
Last fixes were able to decrease needed memory to compile dotc from 1.5Gb to 0.5Gb.
@odersky please have a look.

odersky · 2015-04-30T14:24:42Z

Can you try again with enteredAfter instead of entered and remove the redundant Flags. prefixes? Otherwise LGTM.

Does not fail tests anymore.

Make LazyVals implement non-static modules. Move LV after erasure.

DarkDimius force-pushed the fix-modules branch from b0c7eea to 7c5fa47 Compare April 22, 2015 12:02

odersky force-pushed the fix-modules branch from 7c5fa47 to 7a1a141 Compare April 23, 2015 11:13

DarkDimius force-pushed the fix-modules branch from 154790f to 8d560fa Compare April 23, 2015 16:06

DarkDimius force-pushed the fix-modules branch from c1f4425 to 8260f14 Compare April 28, 2015 09:32

odersky reviewed Apr 28, 2015
View reviewed changes

DarkDimius force-pushed the fix-modules branch from ec0f82f to 75f9784 Compare April 28, 2015 13:57

DarkDimius added 3 commits April 30, 2015 14:26

Mixin: needs to call transformFollowing to make memoize run on traitI…

b1ce9c2

…nits.

Make Constructors change owners.

b50d209

DarkDimius added 18 commits April 30, 2015 14:26

Make Lazy-vals generated fields private.

ca11f55

Fix tpd.ref(sum) to work after erasure.

fc20556

Erasure finishes work done by Explicit outer, and registers a post condition that This(outer) is not allowed.

Update comment on ExplicitOuter.

f892614

We do not plan to have more than Int.MaxValue of lazy vals.

dd65b3e

LazyVals: expected value of flag takes only tree values, no need to u…

086b1c2

…se long.

Disable failing tests. See scala#503

7ef1bd5

LazyVals - do not rely on absence of name clashes in scope.

e24a24d

Was creating correct code, but was assuming that all objects with the same name share same bits. No need to do it.

LazyVals: Synchronized is Object => Object after erasure, scala#505

4a379ec

LazyVals: eagerly enter private symbols.

52c56a2

fix a bug in transformAfter: iterate over a new denotation instead of…

19c8220

… an old one.

Fix bug in transformAfter: transform the last denotation in cycle.

56195fc

Fix spurious warnings in TreeChecker.

4e277dc

LazyVals: last fix that allows to compile -deep dotc.

9bf697c

Enable emmiting byte code for all tests. Compile Dotty.

b5f76e5

Hurray!

Increase heap and stack size on travis.

3b4c230

DottyBackendInterface: interface members cannot be final

c4b61af

Decrease default sizes of buffers.

10d05f3

Values are the ones that I got as maximum values for compiling dotty itself.

Fix two ArrayIndexOutOfBoundsExceptions in TastyBuffer.

ceb2edd

DarkDimius force-pushed the fix-modules branch from 75f9784 to 97181e0 Compare April 30, 2015 13:28

DarkDimius added 2 commits April 30, 2015 15:30

Leave traces for future profiling.

dc21d95

LV: Rename methods.

98f8ab8

DarkDimius force-pushed the fix-modules branch from 97181e0 to 98f8ab8 Compare April 30, 2015 13:30

DarkDimius added 2 commits April 30, 2015 15:42

Comment why LazyVals needs to reorder stats in blocks.

61f0517

LV: change naming convention.

3964a18

Replace .entered by .enteredAfter in LazyVals.

d23e71a

Does not fail tests anymore.

DarkDimius added a commit that referenced this pull request Apr 30, 2015

Merge pull request #493 from dotty-staging/fix-modules

3392ef7

Make LazyVals implement non-static modules. Move LV after erasure.

DarkDimius merged commit 3392ef7 into scala:master Apr 30, 2015

allanrenucci deleted the fix-modules branch December 14, 2017 19:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make LazyVals implement non-static modules. Move LV after erasure. #493

Make LazyVals implement non-static modules. Move LV after erasure. #493

Uh oh!

DarkDimius commented Apr 22, 2015

Uh oh!

DarkDimius commented Apr 22, 2015

Uh oh!

DarkDimius commented Apr 22, 2015

Uh oh!

odersky commented Apr 22, 2015

Uh oh!

DarkDimius commented Apr 23, 2015

Uh oh!

odersky commented Apr 23, 2015

Uh oh!

DarkDimius commented Apr 24, 2015

Uh oh!

DarkDimius commented Apr 28, 2015

Uh oh!

DarkDimius commented Apr 28, 2015

Uh oh!

odersky commented Apr 28, 2015

Uh oh!

odersky Apr 28, 2015

Uh oh!

odersky commented Apr 28, 2015

Uh oh!

DarkDimius commented Apr 28, 2015

Uh oh!

DarkDimius commented Apr 30, 2015

Uh oh!

odersky commented Apr 30, 2015

Uh oh!

Uh oh!

Make LazyVals implement non-static modules. Move LV after erasure. #493

Make LazyVals implement non-static modules. Move LV after erasure. #493

Uh oh!

Conversation

DarkDimius commented Apr 22, 2015

Uh oh!

DarkDimius commented Apr 22, 2015

Uh oh!

DarkDimius commented Apr 22, 2015

Uh oh!

odersky commented Apr 22, 2015

Uh oh!

DarkDimius commented Apr 23, 2015

Uh oh!

odersky commented Apr 23, 2015

Uh oh!

DarkDimius commented Apr 24, 2015

Uh oh!

DarkDimius commented Apr 28, 2015

Uh oh!

DarkDimius commented Apr 28, 2015

Uh oh!

odersky commented Apr 28, 2015

Uh oh!

odersky Apr 28, 2015

Choose a reason for hiding this comment

Uh oh!

odersky commented Apr 28, 2015

Uh oh!

DarkDimius commented Apr 28, 2015

Uh oh!

DarkDimius commented Apr 30, 2015

Uh oh!

odersky commented Apr 30, 2015

Uh oh!

Uh oh!