Skip to content

transformFollowing does not call prepareForXXX #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DarkDimius opened this issue Apr 22, 2015 · 1 comment
Closed

transformFollowing does not call prepareForXXX #494

DarkDimius opened this issue Apr 22, 2015 · 1 comment
Assignees
@DarkDimius
Labels
prio:low

Comments

@DarkDimius
Copy link
Contributor

No description provided.

@DarkDimius DarkDimius self-assigned this Apr 22, 2015
@DarkDimius DarkDimius mentioned this issue Apr 22, 2015
Merged
@DarkDimius
Copy link
Contributor Author

As result of discussion, we currently agreed to leave it as is.
prepareForXXX is very costly, and you do not have guarantee that the phase that invokes transformFollowing actually does this not on a deeply nested tree, ie some calls to prepareForXXX could be inherently missing, because XXX wasn't yet constructed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarkDimius DarkDimius

Labels
prio:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DarkDimius