Skip to content

Print top level packages #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

def main(args: scala.Array[scala.Predef.String]): scala.Unit = {
scala.Predef.println(new foo.A().getClass().getName())
scala.Predef.println(new foo.B().getClass().getName())
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change doesn't seem to affect object printing. Why this is not needed before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the tests are in the empty package. Hence where directly inside the root.

@liufengyun liufengyun merged commit 320583f into scala:master Jun 8, 2018
@liufengyun liufengyun deleted the fix-package-not-printed branch June 8, 2018 11:32
nicolasstucki added a commit to dotty-staging/dotty that referenced this pull request Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants