Skip to content

Fix printing extractors #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 8, 2018

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented May 31, 2018

Extractors in pattern matches were printing case <empty>.Bar.unapply(a) => instead of case Bar(a) =>.

Also added .show of Tasty.Pattern to make it easy to debug.

@nicolasstucki nicolasstucki force-pushed the fix-printing-extractors branch from 1c0c9e9 to 6507d25 Compare June 6, 2018 13:55
@nicolasstucki
Copy link
Contributor Author

Rebased

@nicolasstucki nicolasstucki requested review from liufengyun and removed request for biboudis June 8, 2018 11:14
@nicolasstucki nicolasstucki assigned liufengyun and unassigned biboudis Jun 8, 2018
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit f32aa36 into scala:master Jun 8, 2018
@allanrenucci allanrenucci deleted the fix-printing-extractors branch June 8, 2018 11:35
nicolasstucki added a commit to dotty-staging/dotty that referenced this pull request Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants