Upgrade to sbt 1 #3687
Closed
Upgrade to sbt 1 #3687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First draft at fixing the sbt bridge to match the Zinc 1.0 API.
After sbt/zinc#101, SimpleType simply doesn't exist anymore.
Some of sbt's callbacks need the full name of the class that can only be accessed during the first step of the GenBCode pipeline. So we call the callbacks in the first step, generating at the same time the class files, and keep those files through the whole pipeline so the last step can write the bytecode in them.
A FileConflictException may occure when creating a class file. Add check for this error and refactor a bit of code around it.
That test depended on NameHashing being disabled, which is no longer supported with Zinc 1.0
It isn't passing in sbt/sbt either. See sbt/sbt#3691
It has been changed in sbt/zinc.
Reverted while implementing class-based NameHashing. See: - sbt/zinc@189a2a5 - sbt/zinc#86
Their goal was to offer a simpler alternative to sbt's `F0`. Since `F0` got replaced by `Supplier`, they are no longer required.
For many tests, we need the `scala-library` jar on the classpath, and we used to search through the classpath for a JAR whose name contained `scala-library-2.`. This works great if the `scala-library` on the classpath comes from Ivy. However, if we use the same version of Scala as sbt, the `scala-library` will not be taken ouf of the Ivy cache but from sbt's boot directory. In this case, the JAR will simply be named `scala-library.jar`.
dottybot
reviewed
Dec 21, 2017
allanrenucci
force-pushed
the
topic/sbt1
branch
2 times, most recently
from
f528a01 to
b367467
Compare
allanrenucci
force-pushed
the
topic/sbt1
branch
from
09c68ce to
db410ba
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #3441. Reviews still need to be addressed