Fix #3352: Avoid widening method TermRefs in compatibility checks #3386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When normalizing for a compatibility check we should keep a method reference instead of its widened method type as long as possible. This is because only method references know about default arguments, once we widen to a method type default arguments are no longer taken into account.
odersky
changed the title
liufengyun
reviewed
Oct 25, 2017
Ah yes, missed this one by a digit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When normalizing for a compatibility check we should keep a method reference
instead of its widened method type as long as possible. This is because only
method references know about default arguments, once we widen to a method type
default arguments are no longer taken into account.
Supersedes #3357, from which it takes the essential solution idea.