Fix #3352: defaults parameters require named type in compatibility check #3357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 2 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3357/ to see the changes. Benchmarks is based on merging with master (e1365d9) |
odersky
requested changes
Oct 24, 2017
…ty check In implicit search, if the expected type is applying type and the candidate is a TermRef to a method with default parameters, we need the TermRef to the method in order for `TestApplication` to insert default parameters. Otherwise, by widening the TermRef to MethodType, the information about default parameters is lost, which may incorrectly disqualify a candidate.
|
@odersky : I just updated the PR with more notes. Could you check if there's a better solution to the problem? Thanks. |
|
Thanks for the notes. Now I understand what goes on. I am still not convinced because of the duplication in compatibility checks. This could cost us in complexity and performance. I think it might be better to make normalize not dereference a term type. Let me try this out. |
|
Superseded by #3386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3352: defaults parameters require named type in compatibility check