-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Error on TypedefOrDcl #3325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
allanrenucci
merged 5 commits into
scala:master
from
hermesespinola:hermes_Parsers.scala-line-2150
Oct 19, 2017
Merged
Error on TypedefOrDcl #3325
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1770,7 +1770,7 @@ object messages { | |
|""" | ||
} | ||
|
||
case class ExtendFinalClass(clazz:Symbol, finalClazz: Symbol)(implicit ctx: Context) | ||
case class ExtendFinalClass(clazz:Symbol, finalClazz: Symbol)(implicit ctx: Context) | ||
extends Message(ExtendFinalClassID) { | ||
val kind = "Syntax" | ||
val msg = hl"$clazz cannot extend ${"final"} $finalClazz" | ||
|
@@ -1786,4 +1786,23 @@ object messages { | |
|If you want to create an ${"enum"} case, make sure the corresponding ${"enum class"} exists | ||
|and has the ${"enum"} keyword.""" | ||
} | ||
|
||
case class ExpectedTypeBoundOrEquals()(implicit ctx: Context) | ||
extends Message(ExpectedTypeBoundOrEqualsID) { | ||
val kind = "Syntax" | ||
val msg = | ||
hl"""`=', `>:', or `<:' expected""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't use backquotes. Interpolated strings will be highlighted. For example here: val msg = hl"${"="}, ${">:"}, or ${"<:"} expected" |
||
|
||
val explanation = | ||
hl"""|In Scala, type parameters and abstract types may be constrained by a type bound. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can remove "In Scala" |
||
|Such type bounds limit the concrete values of the type variables and possibly | ||
|reveal more information about the members of such types. | ||
| | ||
|A lower type bound `B >: A` expresses that the type variable `B` | ||
|refers to a supertype of type `A`. | ||
| | ||
|An upper type bound `T <: A` declares that type variable `T` | ||
|refers to a subtype of type `A`. | ||
|""" | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could display the faulty token it in the error message: