Error on TypedefOrDcl #3325
Merged
Error on TypedefOrDcl #3325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Oct 14, 2017
|
Whoops, just signed the CLA, @dotty-bot.
|
allanrenucci
suggested changes
Oct 15, 2017
| hl"""`=', `>:', or `<:' expected""" | ||
|
|
||
| val explanation = | ||
| hl"""|In Scala, type parameters and abstract types may be constrained by a type bound. |
There was a problem hiding this comment.
You can remove "In Scala"
| extends Message(ExpectedTypeBoundOrEqualsID) { | ||
| val kind = "Syntax" | ||
| val msg = | ||
| hl"""`=', `>:', or `<:' expected""" |
There was a problem hiding this comment.
Don't use backquotes. Interpolated strings will be highlighted. For example here:
val msg = hl"${"="}, ${">:"}, or ${"<:"} expected"| @@ -2156,7 +2156,7 @@ object Parsers { | |||
| case SUPERTYPE | SUBTYPE | SEMI | NEWLINE | NEWLINES | COMMA | RBRACE | EOF => | |||
| TypeDef(name, lambdaAbstract(tparams, typeBounds())).withMods(mods).setComment(in.getDocComment(start)) | |||
| case _ => | |||
| syntaxErrorOrIncomplete("`=', `>:', or `<:' expected") | |||
| syntaxErrorOrIncomplete(ExpectedTypeBoundOrEquals()) | |||
There was a problem hiding this comment.
You could display the faulty token it in the error message:
hl"... expected, but ${Tokens.showToken(found)} found"Show faulty token in the error message Don't use backquotes. Remove "In Scala" in explanation message
|
@allanrenucci I changed what you requested and added a test at the end of ErrorMessagesTests.scala. |
| """.stripMargin | ||
| }.expect { (ictx, messages) => | ||
| implicit val ctx: Context = ictx | ||
| val defn = ictx.definitions |
There was a problem hiding this comment.
You don't need defn here.
|
I think it's ok now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles #1589. More specifically, it provides a detailed explanation for the error message in Parsers.scala:2150 : "
=',>:', or `<:' expected".