Skip to content

Fix Overlapping Edit Button on docs #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2017
Merged

Fix Overlapping Edit Button on docs #2758

merged 1 commit into from
Jun 15, 2017

Conversation

Varunram
Copy link
Contributor

Intended as a fix for #2728. I have a small concern though, do we declare a separate class or go ahead with the existing modification? CC: @felixmulder

felixmulder
felixmulder approved these changes Jun 15, 2017
View reviewed changes
Copy link
Contributor

@felixmulder felixmulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine like this! :-)

It's supposed to work for all doc-page-titles anyway!

@felixmulder felixmulder merged commit 7cf6409 into scala:master Jun 15, 2017
@Varunram
Copy link
Contributor Author

Thanks!

@Varunram Varunram deleted the edit-button branch June 15, 2017 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixmulder felixmulder felixmulder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Varunram @felixmulder