Skip to content

Overlapping Edit Button on docs #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Varunram opened this issue Jun 10, 2017 · 2 comments
Closed

Overlapping Edit Button on docs #2728

Varunram opened this issue Jun 10, 2017 · 2 comments

Comments

@Varunram
Copy link
Contributor

Varunram commented Jun 10, 2017

Now that we have a "dit this page on Github" option, this seems to collide with large headings (More than 35 characters long). A fix that occurred to me was was replacing "Github" with the cat icon. What might be an ideal solution for this?

screen shot 2017-06-07 at 6 12 39 pm

@felixmulder
Copy link
Contributor

Hmm, I'd rather we changed the layout of the title. Maybe something like floating two elements right and when the text overlaps we ensure that they're split to different lines. This would also eliminate some of the media query code.

Another option is to look into flexboxing it instead.

WDYT, can you work with this restriction? :)

@Varunram
Copy link
Contributor Author

Yep, will work on it. I'll put in a PR maybe tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants