Add enum exhaustivity checking #2197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @odersky , I'll take over and make it work. |
liufengyun
reviewed
Apr 5, 2017
| private def transformMemberDef(tree: MemberDef)(implicit ctx: Context): Unit = { | ||
| val sym = tree.symbol | ||
| if (sym.is(CaseVal, butNot = Module | Method)) registerChild(sym, sym.info) |
There was a problem hiding this comment.
Nice we have this flag, it simplifies a lot of things 👍
A new kind of child annotation that points to the term symbol representing an enum value.
liufengyun
force-pushed
the
add-enum-exhaustiveness
branch
from
a6ee3d7 to
0c4a06f
Compare
liufengyun
changed the title
Now the algorithm is the same as in the paper.
|
Very nice simplifications! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds exhaustivity checking for enum values on top of #1958. The first new commit is b34a95a. It adds child annotations for sealed enum classes that refer to their enum values. What's new is that the symbols referenced by such annotations can be term symbols. Currently the exhaustivity checking does not deal with term symbols, so some tests fail.
@liufengyun Can you take this PR over and adapt exhaustivity checking?