Skip to content

Exhaustivity check slowdown after enum exhaustivity added #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolasstucki opened this issue Aug 2, 2017 · 3 comments
Closed

Exhaustivity check slowdown after enum exhaustivity added #2940

nicolasstucki opened this issue Aug 2, 2017 · 3 comments
Assignees
@liufengyun
Labels
area:pattern-matching itype:performance

Comments

@nicolasstucki
Copy link
Contributor

In the benchmarks for exhaustivity V we can see that the performance went from 1.5 to 2.3 in #2197.

We should explore if this slowdown is justified and see if we can improve it.
@nicolasstucki
Copy link
Contributor Author

Issue found in liufengyun/bench#11

@nicolasstucki
Copy link
Contributor Author

@liufengyun do you have some more insight?

@liufengyun liufengyun self-assigned this Aug 2, 2017
@allanrenucci
Copy link
Contributor

@nicolasstucki Can we close this? The performance are back to 1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liufengyun liufengyun

Labels
area:pattern-matching itype:performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liufengyun @nicolasstucki @allanrenucci