docs: add in some notes on how to skip tests in the contributing docs #17925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scala#15927 Check for whether the non-scala3 parent exists before checking the start and end of the span to confirm whether the span exists in getParentsAsTreeSymbolTuples.
…bolTuples" (scala#16928) Backports scala#16759
…age in worksheets in the Scala Plugin for IntelliJ IDEA - Calling `setOut/setErr` in a concurrent environment without any synchronization (such as the Scala compile server in the Scala Plugin for IntelliJ IDEA, which is used to execute Scala 3 worksheets) can lead to unpredictable outcomes where the out/err streams are not restored properly after changing. - This change adds a new default method `redirectOutput` which can be overriden by others to control the redirecting behavior of the REPL driver.
…ver for usage in worksheets in the Scala Plugin for IntelliJ IDEA" (scala#16947) Backports scala#16810
Increased timeout due to timeouts when running on dotty community build
The issue was in the encoding into `{ExprMatchModule,TypeMatchModule}.unapply`.
Specifically with the `TypeBindings` argument. This arguments holds the
list of type variable definitions (`tpd.Bind` trees). We used a `Tuple`
to list all the types inside. The problem is that higher-kinded type
variables do not conform with the upper bounds of the tuple elements.
The solution is to use an HList with any-kinded elements.
The issue was in the encoding into
`{ExprMatchModule,TypeMatchModule}.unapply`. Specifically with the
`TypeBindings` argument. This arguments holds the list of type variable
definitions (`tpd.Bind` trees). We used a `Tuple` to list all the types
inside. The problem is that higher-kinded type variables do not conform
with the upper bounds of the tuple elements. The solution is to use an
HList with any-kinded elements.
Backport of scala#16907
In code like:
class Outer:
sealed trait Foo
case class Bar() extends Foo
def mat(foo: Foo) = foo match
case Bar() =>
When in the course of decomposing the scrutinee's type, which is
`Outer.this.Foo`, we're trying to instantiate subclass `Outer.this.Bar`,
the `Outer.this` is fixed - it needn't be inferred, via type variables
and type bounds. Cutting down on type variables, particularly when GADT
symbols are also present, can really speed up the operation, including
making code that used to hang forever compile speedily.
As suggested by @som-snytt in scala#17366 (review)
…n other than a variable or a number literal. This partially reverts the changes from scala#16150. This change is motivated by not breaking source compatibility for a number of projects in the Open Community Build.
…uage specification * Make the parser's warning a migration warning
Co-authored-by: Jamie Thompson <[email protected]>
reorder the source versions
ckipp01
added a commit
to ckipp01/dotty
that referenced
this pull request
Jun 6, 2023
…cala#17925 [skip test] [skip community_build] [skip test_sbt] [skip test_windows_fast] [skip mima]
ckipp01
added a commit
that referenced
this pull request
Jun 12, 2023
…17925 (#17926) [skip test] [skip community_build] [skip test_sbt] [skip test_windows_fast] [skip mima] Rendered it looks like this: <img width="1110" alt="Screenshot 2023-06-06 at 16 15 53" src="https://github.com/lampepfl/dotty/assets/13974112/4b9542a7-cbe2-4068-bfe6-c28418747a94">
Kordyjan
pushed a commit
that referenced
this pull request
Nov 17, 2023
…17925 (#17926) [skip test] [skip community_build] [skip test_sbt] [skip test_windows_fast] [skip mima] Rendered it looks like this: <img width="1110" alt="Screenshot 2023-06-06 at 16 15 53" src="https://github.com/lampepfl/dotty/assets/13974112/4b9542a7-cbe2-4068-bfe6-c28418747a94"> [Cherry-picked 9a58aa2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip test]
[skip community_build]
[skip test_sbt]
[skip test_windows_fast]
Renders like this: