Skip to content

Remove experimental from Mirror#fromProductTyped #16829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mpilquist
Copy link
Contributor

This was first released in 3.1.3 so it seems like it could have @experimental removed. Feel free to close if there's some other process that determines when to remove experimental status for an API addition like this.

@esse-byte
Copy link

Is it the time to remove experimental from scala.util.TupledFunction also ?

@nicolasstucki nicolasstucki added the needs-minor-release This PR cannot be merged until the next minor release label Feb 6, 2023
@mbovel mbovel requested a review from bishabosha February 6, 2023 15:10
@dwijnand dwijnand added this to the 3.4.0 milestone Apr 24, 2023
@bishabosha bishabosha merged commit a210f38 into scala:main Apr 25, 2023
@bishabosha bishabosha added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Apr 25, 2023
@bishabosha
Copy link
Member

@Kordyjan so should this go into 3.3.0? (backports)

@dwijnand
Copy link
Member

I'm not sure it should've been merged into main yet. We're still trying to get 3.3.0 out and probably want main to target 3.3.1 after.

@Kordyjan
Copy link
Contributor

I think the original intent was to have it in 3.3.0, which I'm against, as right now, it is time for ironing out a few last problems, not adding new APIs.

If it was intended to be stabilized in 3.4.0, we must revert the merge and merge it again after branching out release-3.3.1.

@bishabosha I don't know much about mirrors. Is it really important to have this API in LTS?

@bishabosha
Copy link
Member

bishabosha commented Apr 25, 2023

Its something someone can replicate themselves - but what's the point of adding api if they don't get released until 2026 :)

@Kordyjan
Copy link
Contributor

If this is something that we are considering stable and mature or trivial, I can backport it and release it (probably tomorrow) with RC5. Nevertheless, it would be much better if we were stabilizing APIs with RC1, not RC5.

Note to self: before each minor release, we should create an issue with questions about all APIs that may be stabilized instead of only deciding it during the compiler team meeting.

@dwijnand
Copy link
Member

Let's backport this.

@Kordyjan Kordyjan added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Apr 25, 2023
@Kordyjan Kordyjan modified the milestones: 3.4.0, 3.3.0 backports Apr 25, 2023
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels May 15, 2023
@Kordyjan Kordyjan modified the milestones: 3.3.0 backports, 3.3.1, 3.3.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:done This PR was successfully backported. needs-minor-release This PR cannot be merged until the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants