-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove experimental from Mirror#fromProductTyped #16829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental from Mirror#fromProductTyped #16829
Conversation
Is it the time to remove experimental from |
@Kordyjan so should this go into 3.3.0? (backports) |
I'm not sure it should've been merged into main yet. We're still trying to get 3.3.0 out and probably want main to target 3.3.1 after. |
I think the original intent was to have it in 3.3.0, which I'm against, as right now, it is time for ironing out a few last problems, not adding new APIs. If it was intended to be stabilized in 3.4.0, we must revert the merge and merge it again after branching out @bishabosha I don't know much about mirrors. Is it really important to have this API in LTS? |
Its something someone can replicate themselves - but what's the point of adding api if they don't get released until 2026 :) |
If this is something that we are considering stable and mature or trivial, I can backport it and release it (probably tomorrow) with RC5. Nevertheless, it would be much better if we were stabilizing APIs with RC1, not RC5. Note to self: before each minor release, we should create an issue with questions about all APIs that may be stabilized instead of only deciding it during the compiler team meeting. |
Let's backport this. |
This was first released in 3.1.3 so it seems like it could have
@experimental
removed. Feel free to close if there's some other process that determines when to remove experimental status for an API addition like this.