Skip to content

Fix: Correct the nightly version cut off in scaladoc #17024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

Dedelweiss
Copy link
Contributor

@Dedelweiss Dedelweiss commented Feb 28, 2023

In this commit I corrected the cut off of the nightly version by changing :

  • The width in auto for desktop version
  • The max-width in calc(12 * var(--base-spacing)); for better responsiveness

Desktop
Before:
Screenshot 2023-03-01 at 11 04 44

After:
Screenshot 2023-03-01 at 11 04 27

Mobile
Before:
Screenshot 2023-03-01 at 11 13 07

After:
Screenshot 2023-03-01 at 11 07 12

Fixes: #16588

@Dedelweiss Dedelweiss changed the title WIP: Correct the nightly version cut off in scaladoc Fix: Correct the nightly version cut off in scaladoc Mar 1, 2023
@ckipp01 ckipp01 marked this pull request as ready for review March 2, 2023 08:36
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Much better. Thanks for this @Dedelweiss!

This seems good to me! LGTM

I'll re-run the community build since the flaky one failed.

@ckipp01 ckipp01 merged commit 8020c77 into scala:main Mar 2, 2023
@Dedelweiss Dedelweiss deleted the version_cutoff branch March 2, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly version cut off in scaladoc
2 participants