Skip to content

Nightly version cut off in scaladoc #16588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
armanbilge opened this issue Dec 26, 2022 · 0 comments · Fixed by #17024
Closed

Nightly version cut off in scaladoc #16588

armanbilge opened this issue Dec 26, 2022 · 0 comments · Fixed by #17024
Labels
area:doctool area:documentation itype:bug

Comments

@armanbilge
Copy link
Contributor

It renders as 3.3.0-RC1... instead of 3.3.0-RC1-bin-20221224-6f5bb34-NIGHTLY

The problem is the CSS width is not wide enough.
https://github.com/lampepfl/dotty/blob/6f5bb3494f7ad69cbf2eff1fb012b65b7af3cc2d/scaladoc/resources/dotty_res/styles/theme/layout/header.css#L71
@armanbilge armanbilge added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Dec 26, 2022
@nicolasstucki nicolasstucki added area:documentation area:doctool and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Dec 26, 2022
@Dedelweiss Dedelweiss mentioned this issue Mar 1, 2023
Merged
ckipp01 pushed a commit that referenced this issue Mar 2, 2023
@Dedelweiss
Fix: Correct the nightly version cut off in scaladoc (#17024)
8020c77 
In this commit I corrected the cut off of the nightly version by
changing :
- The width in auto for desktop version
- The max-width in `calc(12 * var(--base-spacing));` for better
responsiveness

Desktop
Before:
<img width="994" alt="Screenshot 2023-03-01 at 11 04 44"
src="https://user-images.githubusercontent.com/44496264/222109159-79249ec2-359c-4782-9dcc-88c75ca10454.png">

After:
<img width="1001" alt="Screenshot 2023-03-01 at 11 04 27"
src="https://user-images.githubusercontent.com/44496264/222109141-630a85ef-d2c2-4312-b143-d54f97c2506e.png">

Mobile
Before:
<img width="409" alt="Screenshot 2023-03-01 at 11 13 07"
src="https://user-images.githubusercontent.com/44496264/222109747-253c685e-44ea-4e5d-8330-f2576c729895.png">

After:
<img width="409" alt="Screenshot 2023-03-01 at 11 07 12"
src="https://user-images.githubusercontent.com/44496264/222108968-ae3cc503-cca2-4a65-a76d-9d7e1006e131.png">

Fixes: #16588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:doctool area:documentation itype:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Correct the nightly version cut off in scaladoc Dedelweiss/dotty
2 participants
@armanbilge @nicolasstucki