Skip to content

fix type err, improve readability of patmat doc #16132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bjornregnell
Copy link
Contributor

based on discussion here: #16131

@julienrf
Copy link
Contributor

julienrf commented Oct 3, 2022

Does that overlap with #15993?

@som-snytt
Copy link
Contributor

Indeed. The description here is not accurate about A, but the other PR also does not explain about the type param.

@Sporarum
Copy link
Contributor

Sporarum commented Oct 3, 2022

I will update the other PR with more information about the types

Can this PR therefore be closed ?
(But not merged or deleted, I'll use it as inspiration)

@bjornregnell
Copy link
Contributor Author

bjornregnell commented Oct 3, 2022

ok I'll close this. @som-snytt for curiosity: what would be a more accurate statement about A?
Not that the other PR did not fix the unknown T (should be A) in the unapply signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants