Skip to content

Lots of rewriting for the Scala 3 Reference #15993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 19, 2022

Conversation

Sporarum
Copy link
Contributor

@Sporarum Sporarum commented Sep 7, 2022

Big to small rewritings of the Scala 3 Reference

Mostly yo make it more clear or to improve structure, and fix typos
But there are some specs that were out of date, notably tupling/untupling

@@ -4,37 +4,7 @@ title: "Parameter Untupling - More Details"
nightlyOf: https://docs.scala-lang.org/scala3/reference/other-new-features/parameter-untupling-spec.html
---

## Motivation
Copy link
Contributor Author

@Sporarum Sporarum Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation removed because it was already in the main article (parameter-untupling)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and identical content

@Sporarum Sporarum marked this pull request as ready for review September 13, 2022 13:52
@bishabosha bishabosha self-requested a review September 14, 2022 15:01
@bishabosha bishabosha self-assigned this Sep 14, 2022
@Sporarum
Copy link
Contributor Author

Sporarum commented Oct 11, 2022

@bishabosha
I'll let you review one last time derivation.md, if you accept we can merge
The rest shouldn't have changed since your last review

The derivation.md is not complete, I'll open a different PR to go more into details

@Sporarum
Copy link
Contributor Author

The PR is here: #16170
(Maybe I should have waited to open it not to use CI resources)

@bishabosha
Copy link
Member

bishabosha commented Oct 18, 2022

@Sporarum this needs a rebase, but I have some other points - perhaps this should be split into two PRs.

  1. based on language-reference-stable that only contains changes valid for 3.2.0 - this means changes will be published immediately to docs.scala-lang.org
  2. based on main that adds everything else, these will be published only on dotty.epfl.ch, and then docs.scala-lang.org when 3.2.2 comes out

hopefully it should all be ok to base on the stable branch (as current nightly is still 3.2.x) - but beware of experimental stuff added in patch releases

@Sporarum Sporarum changed the base branch from main to language-reference-stable October 19, 2022 09:27
@Sporarum
Copy link
Contributor Author

@Sporarum this needs a rebase, but I have some other points - perhaps this should be split into two PRs.

1. based on `language-reference-stable` that only contains changes valid for 3.2.0 - this means changes will be published immediately to docs.scala-lang.org

2. based on `main` that adds everything else, these will be published only on dotty.epfl.ch, and then docs.scala-lang.org when 3.2.2 comes out

hopefully it should all be ok to base on the stable branch (as current nightly is still 3.2.x) - but beware of experimental stuff added in patch releases

In the end, everything can be rebased onto language-reference-stable without issue

This PR has been change to point to language-reference-stable as well

@bishabosha Do you think we can merge it ?

bishabosha
bishabosha previously approved these changes Oct 19, 2022
@bishabosha bishabosha dismissed their stale review October 19, 2022 11:22

changes still to come

@bishabosha bishabosha merged commit d282967 into scala:language-reference-stable Oct 19, 2022
@Sporarum Sporarum deleted the fix-reference branch October 20, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants