Test can be skipped #15463
Merged
Test can be skipped #15463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/broken-jdk8-testing
branch
from
b7adb4c to
48595fb
Compare
som-snytt
commented
Jun 24, 2022
| def scalacOptions = toolArgs.get(ToolName.Scalac).getOrElse(Nil) | ||
| def scalacOptions = | ||
| toolArgs.get(ToolName.Scalac) | ||
| .map(args => if args.exists(_.startsWith("-release")) then args else "-release" :: minRelease :: args) |
There was a problem hiding this comment.
actually defaulting -release 8 was deemed problematic, so at best it should be introduced under a test flag of some sort.
Specify release for test
…, still report failures in other tests of the suite
lrytz
force-pushed
the
issue/broken-jdk8-testing
branch
from
48595fb to
c9f692a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test can skip itself. There is no notion of
TestStateandTestReporterwas not modified to carry "skipped" count, but that is a likely follow-up to this commit.Since tests are asked to report on themselves, they must skip doing that when they were skipped.
When
TestReporterreports skipped tests, then the infra can skip asking tests to report.This is a follow-up to #14882 which introduced skipping a test when a minimum JDK version is required.
[test_windows_full]
[test_java8]