Port text block support #14882
Port text block support #14882
Conversation
|
The jvm flag mechanism needs a tweak. |
toolargs supports multi tools Tests need args for scalac, javac and also to specify test conditions such as required jvm version.
som-snytt
force-pushed
the
forward/text-blocks
branch
from
b5e2fb6 to
1dc5fca
Compare
|
Maybe records was going to go on this branch? |
|
It would be nice to have those toolArgs. |
|
Windows tests seem to be failing since this PR. I am having a look now. |
|
I hope it is not the |
|
Maybe it's the Looks like the jdk 8 runs fail irrespective of platform. |
|
@mbovel I can take a look right now; or I may need help knowing how to "skip" a test under vulpix. I remember Lukas added skipping for this test feature under partest. |
Ok, great!
I don't know but I can have a look. |
|
I will add a skip result to vulpix... |
Is the goal to temporary ignore tests? If yes, then wouldn't just moving them to |
|
@mbovel sorry I missed your comment. Yes, moving the test out of the way would have worked for today, and I would have done that as a stop-gap if I hadn't missed your comment. Unfortunately, I noticed the test of scala's java parser need not required jdk 15; only the test using javac need skip on jdk 8. |
| // Inspect the first 10 of the given lines for compiler options of the form | ||
| // scalac: arg1 arg2, with alternative opening, optional space, alt names, text that is not */ up to end. | ||
| // groups are (name, args) | ||
| private val toolArg = raw"(?://|/\*| \*) ?(?i:(${ToolName.values.mkString("|")})):((?:[^*]|\*(?!/))*)".r.unanchored |
toolargs supports multi tools
Tests need args for scalac, javac and also to specify
test conditions such as required jvm version.
Forward port of scala/bug#12290
thanks @harpocrates