Skip to content

CI: move MiMa checks to separate job #14848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2022
Merged

CI: move MiMa checks to separate job #14848

merged 1 commit into from
Apr 5, 2022

Conversation

griggt
Copy link
Contributor

@griggt griggt commented Apr 5, 2022

Closes #14844

@griggt
Copy link
Contributor Author

griggt commented Apr 5, 2022

If this is merged, someone with admin rights should follow up by adding the new MiMa job to the required status checks in the branch protection rules.

@griggt griggt requested a review from anatoliykmetyuk April 5, 2022 02:13
@michelou
Copy link
Contributor

michelou commented Apr 5, 2022

@griggt Thanks 👍

anatoliykmetyuk
anatoliykmetyuk suggested changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the rapid fix!

@anatoliykmetyuk anatoliykmetyuk merged commit 10d1700 into scala:main Apr 5, 2022
@griggt griggt deleted the mima-ci-job branch April 5, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatoliykmetyuk anatoliykmetyuk anatoliykmetyuk requested changes

Assignees

@anatoliykmetyuk anatoliykmetyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move MIMA checks to a separate CI job
3 participants
@griggt @michelou @anatoliykmetyuk