Skip to content

Move MIMA checks to a separate CI job #14844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anatoliykmetyuk opened this issue Apr 4, 2022 · 0 comments · Fixed by #14848
Closed

Move MIMA checks to a separate CI job #14844

anatoliykmetyuk opened this issue Apr 4, 2022 · 0 comments · Fixed by #14848

Comments

@anatoliykmetyuk
Copy link
Contributor

Currently, some of the PRs labelled as needs-minor-release don't pass the CI since they don't properly exclude their changes from MIMA checks. Since this is the case, there is a tendency to automatically blame a CI failure at first glance on MIMA misconfiguration. This is potentially harmful since a legitimate test failure might get into the compiler if a PR that fails the CI and is assumed to do so because of MIMA gets merged.

So, we should move the MIMA checks from the test CI job to a separate job so that if it is immediately clear at first glance if the failure is MIMA or not.

@anatoliykmetyuk anatoliykmetyuk added stat:needs triage Every issue needs to have an "area" and "itype" label itype:bug area:infrastructure and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant