Skip to content

remove TASTy INTERNAL tag #12363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021
Merged

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented May 7, 2021

INTERNAL tag was hardwired to crash in TreeUnpickler since it was first written.

It is also not pickled, so I believe there is no need for a version change.

fixes #12349

@bishabosha bishabosha force-pushed the tasty/remove-internal branch from a8c8b5d to 1ad8a0b Compare May 7, 2021 09:34
@bishabosha bishabosha added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:tasty-format issues relating to TASTy as a portable standard labels May 7, 2021
@bishabosha bishabosha added this to the 3.0.x milestone May 7, 2021
@odersky odersky merged commit 0cd23ac into scala:master May 10, 2021
@odersky odersky deleted the tasty/remove-internal branch May 10, 2021 11:12
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jul 26, 2022
@Kordyjan Kordyjan modified the milestones: 3.0.0, 3.0.1 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tasty-format issues relating to TASTy as a portable standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove INTERNAL flag from TASTy
3 participants