Skip to content

Remove INTERNAL flag from TASTy #12349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bishabosha opened this issue May 6, 2021 · 0 comments · Fixed by #12363
Closed

Remove INTERNAL flag from TASTy #12349

bishabosha opened this issue May 6, 2021 · 0 comments · Fixed by #12363
Assignees
@bishabosha
Labels
area:tasty-format issues relating to TASTy as a portable standard itype:enhancement
Milestone
3.0.1

Comments

@bishabosha
Copy link
Member

There appears to be no reason why there is an INTERNAL flag in TastyFormat, it is never pickled, and when unpickled there is hardwired a crash, this line was updated 6 years ago:

https://github.com/lampepfl/dotty/blob/8957e51230b843a7b3cff6f8e0698aad6f1d778e/compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala#L637

In TastyFormat it is described as meaning "package private (not yet used)", is there still a plan to reserve this as a flag?

cc/ @odersky
@bishabosha bishabosha self-assigned this May 6, 2021
@bishabosha bishabosha added area:tasty-format issues relating to TASTy as a portable standard itype:enhancement labels May 6, 2021
@bishabosha bishabosha mentioned this issue May 7, 2021
Merged
@Kordyjan Kordyjan added this to the 3.0.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bishabosha bishabosha

Labels
area:tasty-format issues relating to TASTy as a portable standard itype:enhancement
Projects
None yet
Milestone
3.0.1
Development

Successfully merging a pull request may close this issue.

remove TASTy INTERNAL tag dotty-staging/dotty
2 participants
@Kordyjan @bishabosha