Fix trait parameter passing algorithm #11410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit faf8716.
As part of the fix, we now also detect missing trait constructors. Fixes scala#11214 Fixes scala#11344
anatoliykmetyuk
requested review from
liufengyun
and removed request for
julienrf
liufengyun
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix algorithm how to pass trait parameters when some of the parameters have independent overrides. With the fix we are back to the rule that for every trait parameter there must be an argument, which is cleaner in the end.
This reverts the spec change for #11214 we did last week. To avoid spec jitter in releases, it would be good to ship this with RC1.