Skip to content

Invalidate member caches after completing classes in Namer #10925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2020
Merged

Invalidate member caches after completing classes in Namer #10925

merged 1 commit into from
Dec 29, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 27, 2020

Fixes #10634

@odersky odersky requested a review from adpi2 December 27, 2020 14:42
@odersky
Copy link
Contributor Author

odersky commented Dec 27, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 7 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/10925/ to see the changes.

Benchmarks is based on merging with master (8fab91c)

adpi2
adpi2 approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @odersky, it indeed fixes the issue in #10634.

I let you judge the impact of invalidateMemberCaches in terms of performance.

@odersky
Copy link
Contributor Author

odersky commented Dec 28, 2020 •
edited by liufengyun
Loading

test performance please

@liufengyun
Copy link
Contributor

liufengyun commented Dec 28, 2020 •
edited
Loading

We have a little problem with the bench server. I'm on it.

Updated: Now the server is back.

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

@odersky
Copy link
Contributor Author

odersky commented Dec 29, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 2 job(s) in queue, 1 running.

@liufengyun
Copy link
Contributor

We still have a problem with the bench server (after the file system fix yesterday), I'm investigating.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/10925/ to see the changes.

Benchmarks is based on merging with master (ca02d83)

@odersky odersky merged commit d932af9 into scala:master Dec 29, 2020
@odersky odersky deleted the fix-#10634 branch December 29, 2020 17:39
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpi2 adpi2 adpi2 approved these changes

Assignees

@adpi2 adpi2

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Order of the source files changes the compilation result
5 participants
@odersky @dottybot @liufengyun @adpi2 @Kordyjan