Merge pull request #10939 from prolativ/fix-implicit-conversion-warnings

Fix #10259: Don't complain about old style conversion for extension method

Author: smarter

compiler/src/dotty/tools/dotc/typer/Implicits.scala

@@ -792,8 +792,8 @@ trait Implicits:
         val inferred = inferImplicit(adjust(to), from, from.span)
 
         inferred match {
-          case SearchSuccess(_, ref, _) =>
-            if isOldStyleFunctionConversion(ref.underlying) then
+          case SearchSuccess(tree, ref, _)
+            if isOldStyleFunctionConversion(ref.underlying) && !tree.isInstanceOf[Applications.ExtMethodApply] =>
               report.migrationWarning(
                 i"The conversion ${ref} will not be applied implicitly here in Scala 3 because only implicit methods and instances of Conversion class will continue to work as implicit views.",
                 from

tests/pos-special/fatal-warnings/i10259.scala

@@ -0,0 +1,8 @@
+trait S[T] extends (T => T):
+  def apply(x: T) = ???
+  extension (x: T) def show: String
+
+given S[Int] with
+  extension (x: Int) def show = x.toString
+
+val x = 10.show