Skip to content

Improve performance of Unlifted.unapply #10561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Improve performance of Unlifted.unapply #10561

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a302f0
Improve performance of `Unlifted.unapply`
nicolasstucki Nov 30, 2020
5b11dc3
Add missing empty arguments
nicolasstucki Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions library/src/scala/quoted/Unlifted.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,13 @@ object Unlifted {
* }
* ```
*/
def unapply[T](exprs: Seq[Expr[T]])(using unlift: Unliftable[T], qctx: Quotes): Option[Seq[T]] =
exprs.foldRight(Option(List.empty[T])) { (elem, acc) =>
(elem, acc) match {
case (Unlifted(value), Some(lst)) => Some(value :: lst)
case (_, _) => None
}
}
def unapply[T](exprs: Seq[Expr[T]])(using Unliftable[T])(using Quotes): Option[Seq[T]] =
val builder = Seq.newBuilder[T]
val iter = exprs.iterator
while iter.hasNext do
iter.next() match
case Unlifted(value) => builder += value
case _ => return None
Some(builder.result())

}