Skip to content

Improve performance of Unlifted.unapply #10561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2020
Merged

Improve performance of Unlifted.unapply #10561

merged 2 commits into from
Nov 30, 2020

Conversation

nicolasstucki
Copy link
Contributor

  • Avoid creation of Options and fail fast
  • Align signatures

@nicolasstucki
Improve performance of Unlifted.unapply
3a302f0 
* Avoid creation of `Option`s and fail fast
* Align signatures
@nicolasstucki nicolasstucki force-pushed the improve-Unlifted-performance branch from 7232231 to 3a302f0 Compare November 30, 2020 15:30
@nicolasstucki
Copy link
Contributor Author

test performance with #quotes please

@dottybot
Copy link
Member

performance test scheduled: 4 job(s) in queue, 0 running.

@nicolasstucki
Copy link
Contributor Author

I do not expect a large performance improvement

@liufengyun
Copy link
Contributor

@nicolasstucki I stopped the benchmarking service, as we have merge problems.

@nicolasstucki
Copy link
Contributor Author

It is not that important. The signature change seems to be more important.

@nicolasstucki nicolasstucki added this to the 3.0.0-M3 milestone Nov 30, 2020
@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/10561/ to see the changes.

Benchmarks is based on merging with master (31751b9)

@liufengyun
Copy link
Contributor

There is a big drop 👍

@nicolasstucki nicolasstucki marked this pull request as ready for review November 30, 2020 20:47
liufengyun
liufengyun approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki
Copy link
Contributor Author

@liufengyun looking at the benchmark, this improvement does not make sense. We do not even use that extractor in this branch. Maybe the CPU profile got reset again.

@liufengyun
Copy link
Contributor

@liufengyun looking at the benchmark, this improvement does not make sense. We do not even use that extractor in this branch. Maybe the CPU profile got reset again.

We didn't reboot, thus the CPU should be the same as before. It could be that the speedup comes from other untested merges.

@nicolasstucki nicolasstucki merged commit b2a09d3 into scala:master Nov 30, 2020
@nicolasstucki nicolasstucki deleted the improve-Unlifted-performance branch November 30, 2020 21:22
@Kordyjan Kordyjan modified the milestones: 3.0.0-M3, 3.0.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasstucki @dottybot @liufengyun @Kordyjan