Skip to content

Make assert work as a plain inline function #10354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 20, 2020
Merged

Make assert work as a plain inline function #10354

merged 6 commits into from
Nov 20, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Nov 17, 2020 •
edited
Loading

Two things needed for this:

  • Correctly propagate nullInfos across ReTyper.
  • Optimize (expr: Unit) ascriptions in erasure

Based on #10302

@odersky
Drop duplicate methods in DottyPredef
5049689 
Drop some methods in DottyPredef that are also in Predef
@odersky
Fixes
126ad64 
  - bring back valueOf, the old one fails many tests
  - correct check file
  - exclude pickling test involving Predef.implicitly
@odersky
Disable inline bytecode test
63fa893
@odersky
Update semanticDB files
9c4f6f2
@odersky
Propagate notNullinfo in ReTyper
fe6c10f 
the case of `typedTyped` was missing. This allows to use a plain inline
`assert` in DottyPredef.
@odersky
Fix Unit ascriptions in erasure
a483d4a 
We should simply drop a Unit ascription, not ascribe BoxedUnit instead. This fixes
a case in `nullAsInstanceOf.scala`. Now

    null.asInstanceOf[Unit]

is `()`, whereas before it was `null` `()` is correct, or at least it
is the same behavior as for all other primitive types.
@odersky odersky requested a review from sjrd November 20, 2020 13:04
@odersky odersky merged commit de3fbe2 into scala:master Nov 20, 2020
@odersky odersky deleted the opaquify-assert branch November 20, 2020 14:16
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd Awaiting requested review from sjrd

Assignees

@sjrd sjrd

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @sjrd @Kordyjan