Skip to content

Drop duplicate methods in DottyPredef #10302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 20, 2020
Merged

Drop duplicate methods in DottyPredef #10302

merged 4 commits into from
Nov 20, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Nov 13, 2020

Drop some methods in DottyPredef that are also in Predef

@odersky odersky mentioned this pull request Nov 13, 2020
Closed
@odersky
Drop duplicate methods in DottyPredef
5049689 
Drop some methods in DottyPredef that are also in Predef
@odersky
Fixes
126ad64 
  - bring back valueOf, the old one fails many tests
  - correct check file
  - exclude pickling test involving Predef.implicitly
@odersky
Disable inline bytecode test
63fa893
@odersky
Update semanticDB files
9c4f6f2
@odersky odersky force-pushed the reduce-dottypredef branch 2 times, most recently from 5e8c8f7 to 9c4f6f2 Compare November 17, 2020 12:31
@odersky odersky mentioned this pull request Nov 17, 2020
Merged
sjrd
sjrd approved these changes Nov 17, 2020
View reviewed changes
compiler/test/dotty/tools/backend/jvm/InlineBytecodeTests.scala
@@ -73,7 +73,9 @@ class InlineBytecodeTests extends DottyBytecodeTest {
}
}

@Test def inlineLocally = {
/** Disabled since locally comes from Predef now
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider actually removing the code instead of commenting it out.

@sjrd
Copy link
Member

sjrd commented Nov 19, 2020

@odersky Not sure whether you had seen my comment, since I posted here about 30 seconds before you assigned me as a reviewer.

@odersky odersky merged commit dda6be5 into scala:master Nov 20, 2020
@odersky odersky deleted the reduce-dottypredef branch November 20, 2020 13:04
@griggt griggt mentioned this pull request Nov 28, 2020
Closed
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees

@sjrd sjrd

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @sjrd @Kordyjan