Skip to content

Remove internal.quoted.showName #10176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 4, 2020

At the Expr level of abstractions, the string representation of the name holds no semantic meaning.
The same behaviour can be encoded with reflect.Block.let("myVal", rhs)(body) in #10175.

@nicolasstucki nicolasstucki marked this pull request as ready for review November 5, 2020 09:54
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice simplification 👍

@nicolasstucki nicolasstucki merged commit df52911 into scala:master Nov 5, 2020
@nicolasstucki nicolasstucki deleted the remove-show-name branch November 5, 2020 10:19
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants