Move let to ValDef and fix signature #10175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
move-reflection-let
branch
from
f9b569e to
34d234f
Compare
nicolasstucki
force-pushed
the
move-reflection-let
branch
3 times, most recently
from
914ff65 to
cee7671
Compare
liufengyun
reviewed
Nov 5, 2020
nicolasstucki
force-pushed
the
move-reflection-let
branch
2 times, most recently
from
927a077 to
b8c4ee7
Compare
nicolasstucki
changed the title
Rather than remove it as originally planed, we keep it under Block as it creates a block with vals. Both signatures take an return an Ident now. Also add variant of let with custom name
nicolasstucki
force-pushed
the
move-reflection-let
branch
from
b8c4ee7 to
ba91147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than remove it as originally planed, we keep it under ValDef as it creates a block with vals.
Both signatures take an return an Ident now.