Skip to content

Fix #1009: Do not forget to skolemize some types #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2016

Conversation

smarter
Copy link
Member

@smarter smarter commented Dec 23, 2015

Review by @odersky

@smarter smarter force-pushed the fix/new-asSeenFrom branch 2 times, most recently from a7b4c14 to b44d12e Compare December 24, 2015 15:45
@smarter
Copy link
Member Author

smarter commented Dec 24, 2015

PR updated to reflect dotty-staging@a7b4c14#commitcomment-15152817

@smarter smarter changed the title Fix #1009: Do not forget to skolemize some illegal prefixes Fix #1009: Do not forget to skolemize some types Dec 24, 2015
@smarter
Copy link
Member Author

smarter commented Dec 24, 2015

/rebuild

@smarter
Copy link
Member Author

smarter commented Dec 24, 2015

From https://scala-ci.typesafe.com/job/dotty-master-validate-partest/853/consoleFull :

[error] java.lang.OutOfMemoryError: GC overhead limit exceeded

@DarkDimius: should we raise the amount of memory we use? Or should we investigate why we're using so much memory?

@smarter
Copy link
Member Author

smarter commented Dec 24, 2015

Updated the PR with a small optimization: do not allocate an AsSeenFromMap if TypeAlias#variance == 1.

odersky added a commit that referenced this pull request Jan 3, 2016
Fix #1009: Do not forget to skolemize some types
@odersky odersky merged commit be3ab3f into scala:master Jan 3, 2016
@allanrenucci allanrenucci deleted the fix/new-asSeenFrom branch December 14, 2017 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants