Fix #1009: Do not forget to skolemize some illegal prefixes

Author: smarter

src/dotty/tools/dotc/core/TypeOps.scala

@@ -45,8 +45,10 @@ trait TypeOps { this: Context => // TODO: Make standalone object.
    *  The scheme is efficient in particular because we expect that unsafe situations are rare;
    *  most compiles would contain none, so no scanning would be necessary.
    */
-  final def asSeenFrom(tp: Type, pre: Type, cls: Symbol): Type =
-    asSeenFrom(tp, pre, cls, null)
+  final def asSeenFrom(tp: Type, pre: Type, cls: Symbol): Type = {
+    val m = if (isLegalPrefix(pre)) null else new AsSeenFromMap(pre, cls)
+    asSeenFrom(tp, pre, cls, m)
+  }
 
   /** Helper method, taking a map argument which is instantiated only for more
    *  complicated cases of asSeenFrom.

test/dotc/tests.scala

@@ -172,6 +172,7 @@ class tests extends CompilerTest {
   @Test def neg_validate = compileFile(negDir, "validate", xerrors = 18)
   @Test def neg_validateParsing = compileFile(negDir, "validate-parsing", xerrors = 7)
   @Test def neg_validateRefchecks = compileFile(negDir, "validate-refchecks", xerrors = 2)
+  @Test def neg_skolemize = compileFile(negDir, "skolemize", xerrors = 2)
 
   @Test def run_all = runFiles(runDir)
 

tests/neg/skolemize.scala

@@ -0,0 +1,13 @@
+class Contra[-T]
+
+class Foo {
+  val foo: Contra[this.type] = new Contra[this.type]
+}
+object Test {
+  def test: Unit = {
+    val e1 = new Foo
+    val f1: Contra[Foo] = e1.foo // error
+    var e2 = new Foo
+    val f2: Contra[Foo] = e2.foo // error
+  }
+}