Merge pull request #1008 from dotty-staging/fix-sym-positions

Fix off by 2 error for symbol positions

Author: smarter

src/dotty/tools/dotc/util/Positions.scala

@@ -158,7 +158,7 @@ object Positions {
     }
     def toPosition = {
       assert(isPosition)
-      if (this == NoCoord) NoPosition else Position(1 - encoding)
+      if (this == NoCoord) NoPosition else Position(-1 - encoding)
     }
   }
 

test/dotc/tests.scala

@@ -143,7 +143,7 @@ class tests extends CompilerTest {
   @Test def neg_badAuxConstr = compileFile(negDir, "badAuxConstr", xerrors = 2)
   @Test def neg_typetest = compileFile(negDir, "typetest", xerrors = 1)
   @Test def neg_t1569_failedAvoid = compileFile(negDir, "t1569-failedAvoid", xerrors = 1)
-  @Test def neg_clashes = compileFile(negDir, "clashes", xerrors = 3)
+  @Test def neg_clashes = compileFile(negDir, "clashes", xerrors = 2)
   @Test def neg_cycles = compileFile(negDir, "cycles", xerrors = 8)
   @Test def neg_boundspropagation = compileFile(negDir, "boundspropagation", xerrors = 5)
   @Test def neg_refinedSubtyping = compileFile(negDir, "refinedSubtyping", xerrors = 2)

tests/neg/clashes.scala

@@ -1,6 +1,6 @@
 object Test {
   class C
-  type C
+  type C   // error
 }
 
-object Test
+object Test  // error