Skip to content

Various compiler error messages still mention "implicit" #7710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hseeberger opened this issue Dec 10, 2019 · 3 comments · Fixed by #14718
Closed

Various compiler error messages still mention "implicit" #7710

hseeberger opened this issue Dec 10, 2019 · 3 comments · Fixed by #14718
Labels
area:reporting Error reporting including formatting, implicit suggestions, etc exp:novice itype:enhancement Spree Suitable for a future Spree stat:needs spec
Milestone

Comments

@hseeberger
Copy link

hseeberger commented Dec 10, 2019

Compiler Version

3.0.2

Minimised Code

trait Foo

def foo()(using Foo) = println("foo")

def test = foo()

Output

-- Error: i7710.scala:5:16 -------------------------------------------
5 |def test = foo()
  |                ^
  |no implicit argument of type Foo was found for parameter x$1 of method foo
1 error found

Expectation

Shouldn't the message mention "given"?

@bishabosha
Copy link
Member

bishabosha commented Dec 10, 2019

While the keyword has changed, the current terminology is still implicit parameter within a given clause, as seen in http://dotty.epfl.ch/docs/reference/contextual/given-clauses.html. But various sorts of cohesion enhancements should take place in errors

@bishabosha
Copy link
Member

we should use the suggestion given in this comment #9874 (comment)

@julienrf
Copy link
Contributor

What is the conclusion here about the jargon we should use? Do we still use “implicit parameters”? Or do we now use “context parameters”?

@anatoliykmetyuk anatoliykmetyuk added the Spree Suitable for a future Spree label Jul 21, 2021
@bishabosha bishabosha assigned bishabosha and unassigned bishabosha Aug 23, 2021
ckipp01 added a commit to ckipp01/dotty that referenced this issue Mar 20, 2022
This changes some of the remaining messages that warn about "no
implicit" to the new verbiage of "no given instance".

fixes scala#7710
ckipp01 added a commit to ckipp01/dotty that referenced this issue Mar 20, 2022
This changes some of the remaining messages that warn about "no
implicit" to the new verbiage of "no given instance".

fixes scala#7710
ckipp01 added a commit to ckipp01/dotty that referenced this issue Mar 20, 2022
This changes some of the remaining messages that warn about "no
implicit" to the new verbiage of "no given instance".

fixes scala#7710
ckipp01 added a commit to ckipp01/dotty that referenced this issue Mar 20, 2022
This changes some of the remaining messages that warn about "no
implicit" to the new verbiage of "no given instance".

fixes scala#7710
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:reporting Error reporting including formatting, implicit suggestions, etc exp:novice itype:enhancement Spree Suitable for a future Spree stat:needs spec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants