Skip to content

Should the error message be updated to given instead of implicit when the given instance of missing #14717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
He-Pin opened this issue Mar 20, 2022 · 3 comments
Closed

Should the error message be updated to given instead of implicit when the given instance of missing #14717

He-Pin opened this issue Mar 20, 2022 · 3 comments
Assignees
@ckipp01
Labels
area:reporting Error reporting including formatting, implicit suggestions, etc itype:bug

Comments

@He-Pin
Copy link
Contributor

He-Pin commented Mar 20, 2022 •
edited
Loading

Compiler version

Scala3.1.1

Minimized code

summon[Int]

Output

no implicit argument of type Int was found for parameter x of method summon in object Predef

Expectation

no given instance of type Int was found for parameter x of method summon in object Predef

As in Scala 3 we are providing an using argument which is a given instance.
@He-Pin He-Pin added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label labels Mar 20, 2022
@ckipp01
Copy link
Member

ckipp01 commented Mar 20, 2022

Thanks for submission! I just push #14718 to address this, but it can also probably be marked as a duplicate of #7710.

@odersky odersky added area:reporting Error reporting including formatting, implicit suggestions, etc and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Mar 20, 2022
@odersky
Copy link
Contributor

odersky commented Mar 20, 2022

I just merged #14718. @ckipp01 can this issue be closed now, or should we leave it open?

@ckipp01
Copy link
Member

ckipp01 commented Mar 20, 2022

Yup, this one is now taken care of with the changes in #14718

scala> summon[Int]
-- Error: ----------------------------------------------------------------------
1 |summon[Int]
  |           ^
  |no given instance of type Int was found for parameter x of method summon in object Predef
1 error found

@ckipp01 ckipp01 closed this as completed Mar 20, 2022
@SethTisue SethTisue changed the title Should the error message be updated to givien instead of implicit when the given instance of missing Should the error message be updated to given instead of implicit when the given instance of missing Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckipp01 ckipp01

Labels
area:reporting Error reporting including formatting, implicit suggestions, etc itype:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@He-Pin @odersky @ckipp01