-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove dependency on scala-xml #5597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
but there could be issues related to xml support that only manifest themselves after parsing (e.g. I think #3235 fixed a crash in Typer#assertPositioned) |
True. But is seems to be the
I can only find calls to Nothing prevent us to keep checking this after parsing |
scalac has the advantage that scala-xml is built using it and has its own test suite, if we add scala-xml to our community build and run its tests then I guess that would be good enough too. |
scala-xml would probably accept a pull request adding Dotty to their |
…build This means that our test suites can no longer contain xml tests, instead they need to be added to scala-xml like this: scala/scala-xml@9762438
…build This means that our test suites can no longer contain xml tests, instead they need to be added to scala-xml like this: scala/scala-xml@9762438
…build This means that our test suites can no longer contain xml tests, instead they need to be added to scala-xml like this: scala/scala-xml@9762438
…build This means that our test suites can no longer contain xml tests, instead they need to be added to scala-xml like this: scala/scala-xml@9762438
…build This means that our test suites can no longer contain xml tests, instead they need to be added to scala-xml like this: scala/scala-xml@9762438
…build This means that our test suites can no longer contain xml tests, instead they need to be added to scala-xml like this: scala/scala-xml@9762438
…build This means that our test suites can no longer contain xml tests, instead they need to be added to scala-xml like this: scala/scala-xml@9762438
…build This means that our test suites can no longer contain xml tests, instead they need to be added to scala-xml like this: scala/scala-xml@9762438
Fix #5597: Remove scala-xml dependency, add it to the community-build
We still bring in
scala-xml
to run our tests. We should:scala-xml
is not on the classpath similarly to scalac.-Ystop-after:parser
for tests that parse xmlThe text was updated successfully, but these errors were encountered: