Fix #5597: Remove scala-xml dependency, add it to the community-build

This means that our test suites can no longer contain xml tests, instead
they need to be added to scala-xml like this:
scala/scala-xml@9762438

Author: smarter

.gitmodules

@@ -37,3 +37,6 @@
 [submodule "community-build/community-projects/sourcecode"]
 	path = community-build/community-projects/sourcecode
 	url = https://github.com/dotty-staging/sourcecode
+[submodule "community-build/community-projects/scala-xml"]
+	path = community-build/community-projects/scala-xml
+	url = https://github.com/scala/scala-xml

community-build/community-projects/scala-xml

@@ -109,6 +109,12 @@ class CommunityBuildTest {
     updateCommand = "scalatest/update"
   )
 
+  @Test def scalaXml = test(
+    project       = "scala-xml",
+    testCommand   = "xml/test",
+    updateCommand = "xml/update"
+  )
+
   @Test def scopt = test(
     project       = "scopt",
     testCommand   = "scoptJVM/compile",

community-build/community-projects/scalatest

@@ -59,9 +59,6 @@ object Properties {
   /** scala-asm jar */
   def scalaAsm: String = sys.props("dotty.tests.classes.scalaAsm")
 
-  /** scala-xml jar */
-  def scalaXml: String = sys.props("dotty.tests.classes.scalaXml")
-
   /** jline-terminal jar */
   def jlineTerminal: String = sys.props("dotty.tests.classes.jlineTerminal")
 

community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala

@@ -12,7 +12,7 @@ object TestConfiguration {
   )
 
   val checkOptions = Array(
-    // "-Yscala2-unpickler", s"${Properties.scalaLibrary}:${Properties.scalaXml}",
+    // "-Yscala2-unpickler", s"${Properties.scalaLibrary}",
     "-Yno-deep-subtypes",
     "-Yno-double-bindings",
     "-Yforce-sbt-phases",
@@ -21,13 +21,11 @@ object TestConfiguration {
 
   val basicClasspath = mkClasspath(List(
     Properties.scalaLibrary,
-    Properties.scalaXml,
     Properties.dottyLibrary
   ))
 
   val withCompilerClasspath = mkClasspath(List(
     Properties.scalaLibrary,
-    Properties.scalaXml,
     Properties.scalaAsm,
     Properties.jlineTerminal,
     Properties.jlineReader,

compiler/test/dotty/Properties.scala

@@ -450,8 +450,6 @@ object Build {
       // get libraries onboard
       libraryDependencies ++= Seq(
         "org.scala-lang.modules" % "scala-asm" % "6.0.0-scala-1", // used by the backend
-        // FIXME: Not needed, but should be on the compiler CP
-        ("org.scala-lang.modules" %% "scala-xml" % "1.1.0").withDottyCompat(scalaVersion.value),
         "org.scala-lang" % "scala-library" % scalacVersion % "test",
         Dependencies.`compiler-interface`,
         "org.jline" % "jline-reader" % "3.9.0",   // used by the REPL
@@ -515,7 +513,6 @@ object Build {
           "-Ddotty.tests.classes.compilerInterface=" + findLib(attList, "compiler-interface"),
           "-Ddotty.tests.classes.scalaLibrary=" + findLib(attList, "scala-library-"),
           "-Ddotty.tests.classes.scalaAsm=" + findLib(attList, "scala-asm"),
-          "-Ddotty.tests.classes.scalaXml=" + findLib(attList, "scala-xml"),
           "-Ddotty.tests.classes.jlineTerminal=" + findLib(attList, "jline-terminal"),
           "-Ddotty.tests.classes.jlineReader=" + findLib(attList, "jline-reader")
         )