This repository was archived by the owner on Sep 8, 2022. It is now read-only.
Issue #25 use filtered check for git diff #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike normal diff, the git diff feature wasn't using the filtered
check file under `--show-diff`.
Now the sample displays just the bad line.
```
!! 1 - neg/t7494-no-options [output differs]
% diff /home/apm/projects/snytt/test/files/neg/t7494-no-options-neg.log /home/apm/projects/snytt/test/files/neg/t7494-no-options.check
@@ -1,7 +1,7 @@
error: Error: ploogin takes no options
phase name id description
---------- -- -----------
- parser 1 parse source into ASTs, perform simple desugaring
+ parser 0 parse source into ASTs, perform simple desugaring
namer 2 resolve names, attach symbols to named trees
packageobjects 3 load package objects
typer 4 the meat and potatoes: type the trees
```
SethTisue
added a commit
that referenced
this pull request
Sep 23, 2015
Issue #25 use filtered check for git diff
|
thanks Som! this looks Fein. wrong diffs are our Feind. |
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Issue scala#25 use filtered check for git diff
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Issue scala#25 use filtered check for git diff
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike normal diff, the git diff feature wasn't using the filtered
check file under
--show-diff.Now the sample displays just the bad line.