This repository was archived by the owner on Sep 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Checkfiles are not properly preprocessed when diffing #25
Comments
som-snytt
added a commit
to som-snytt/scala-partest
that referenced
this issue
Sep 19, 2015
Unlike normal diff, the git diff feature wasn't using the filtered check file under `--show-diff`. Now the sample displays just the bad line. ``` !! 1 - neg/t7494-no-options [output differs] % diff /home/apm/projects/snytt/test/files/neg/t7494-no-options-neg.log /home/apm/projects/snytt/test/files/neg/t7494-no-options.check @@ -1,7 +1,7 @@ error: Error: ploogin takes no options phase name id description ---------- -- ----------- - parser 1 parse source into ASTs, perform simple desugaring + parser 0 parse source into ASTs, perform simple desugaring namer 2 resolve names, attach symbols to named trees packageobjects 3 load package objects typer 4 the meat and potatoes: type the trees ```
This was just the extra-fancy git diff feature. The plain old gitless diff used the filtered check. |
SethTisue
added a commit
that referenced
this issue
Sep 23, 2015
Issue #25 use filtered check for git diff
resolved by #39 |
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this issue
May 9, 2018
Unlike normal diff, the git diff feature wasn't using the filtered check file under `--show-diff`. Now the sample displays just the bad line. ``` !! 1 - neg/t7494-no-options [output differs] % diff /home/apm/projects/snytt/test/files/neg/t7494-no-options-neg.log /home/apm/projects/snytt/test/files/neg/t7494-no-options.check @@ -1,7 +1,7 @@ error: Error: ploogin takes no options phase name id description ---------- -- ----------- - parser 1 parse source into ASTs, perform simple desugaring + parser 0 parse source into ASTs, perform simple desugaring namer 2 resolve names, attach symbols to named trees packageobjects 3 load package objects typer 4 the meat and potatoes: type the trees ```
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this issue
May 9, 2018
Issue scala#25 use filtered check for git diff
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this issue
May 9, 2018
Unlike normal diff, the git diff feature wasn't using the filtered check file under `--show-diff`. Now the sample displays just the bad line. ``` !! 1 - neg/t7494-no-options [output differs] % diff /home/apm/projects/snytt/test/files/neg/t7494-no-options-neg.log /home/apm/projects/snytt/test/files/neg/t7494-no-options.check @@ -1,7 +1,7 @@ error: Error: ploogin takes no options phase name id description ---------- -- ----------- - parser 1 parse source into ASTs, perform simple desugaring + parser 0 parse source into ASTs, perform simple desugaring namer 2 resolve names, attach symbols to named trees packageobjects 3 load package objects typer 4 the meat and potatoes: type the trees ```
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this issue
May 9, 2018
Issue scala#25 use filtered check for git diff
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Under
--show-diff
, things like these happen:Note the
#partest
lines. They should be processed just like when comparing, before doing the diff.The text was updated successfully, but these errors were encountered: