Skip to content

Fix setup instructions #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fix setup instructions #1469

merged 2 commits into from
Feb 15, 2023

Conversation

julienrf
Copy link
Contributor

Consistent with scala/docs.scala-lang#2698

@julienrf julienrf requested a review from bishabosha February 14, 2023 09:39
@@ -9,7 +9,10 @@
{% assign homebrewAlt = "Alternatively, if you don't use Homebrew:" %}
Copy link
Member

@bishabosha bishabosha Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% assign homebrewAlt = "Alternatively, if you don't use Homebrew:" %}
{% assign homebrewAlt = "Alternatively for Apple Silicon, or if you don't use Homebrew:" %}

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally I approve, but the Homebrew link installs the x86 version so I think the alt-details label text should reflect this

@julienrf
Copy link
Contributor Author

Ah, good point. But I wonder if we could fix the homebrew formula instead to download the correct binary.

@bishabosha
Copy link
Member

bishabosha commented Feb 15, 2023

Ah, good point. But I wonder if we could fix the homebrew formula instead to download the correct binary.

then at the point that the formula is fixed, we revert the title :)

@julienrf julienrf merged commit b077fbb into scala:main Feb 15, 2023
@julienrf julienrf deleted the fix-setup branch February 15, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants